Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use development logging when running a local build #889

Merged
merged 3 commits into from
Apr 29, 2020
Merged

Use development logging when running a local build #889

merged 3 commits into from
Apr 29, 2020

Commits on Apr 29, 2020

  1. Use development logging when running a local build 

    The [zap development
logger](https://godoc.org/go.uber.org/zap#NewDevelopmentConfig) provides nicer
console output as well as a few other different defaults for development.

To decide whether to use production or development it's checking if `Version`
has been set at build time. If not it assumes it's development. It may be
better not to conflate version number with build type in which case we could
add a separate build type. But first I wanted to see if the general idea
desirable.
    @jrcamp
    jrcamp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    b9c3442 View commit details
    Browse the repository at this point in the history

  2. add log profile flag

    @jrcamp
    jrcamp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    6d84c94 View commit details
    Browse the repository at this point in the history

  3. add build variable

    @jrcamp
    jrcamp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    0d22e21 View commit details
    Browse the repository at this point in the history