Use development logging when running a local build #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [zap development logger](https://godoc.org/go.uber.org/zap#NewDevelopmentConfig) provides nicer console output as well as a few other different defaults for development. To decide whether to use production or development it's checking if `Version` has been set at build time. If not it assumes it's development. It may be better not to conflate version number with build type in which case we could add a separate build type. But first I wanted to see if the general idea desirable.
jrcamp
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
pjanotti
reviewed
Apr 29, 2020
|
+1 can we make it a CLI flag so same build can do both? |
|
Err sorry, still have to add the separate control var so ignore the review request temporarily. :) |
Codecov Report
@@ Coverage Diff @@
## master #889 +/- ##
==========================================
- Coverage 85.99% 85.94% -0.05%
==========================================
Files 166 166
Lines 12980 12993 +13
==========================================
+ Hits 11162 11167 +5
- Misses 1396 1403 +7
- Partials 422 423 +1
Continue to review full report at Codecov.
|
pjanotti
approved these changes
Apr 29, 2020
| ) | ||
|
|
||
| const ( | ||
| logLevelCfg = "log-level" | ||
| logLevelCfg = "log-level" | ||
| logProfileCfg = "log-profile" |
There was a problem hiding this comment.
I wonder if we want to make this more generic, ie.: use profile for other things but this is already a good start. Let's keep as it is at least for now.
6 tasks
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
* Use development logging when running a local build The [zap development logger](https://godoc.org/go.uber.org/zap#NewDevelopmentConfig) provides nicer console output as well as a few other different defaults for development. To decide whether to use production or development it's checking if `Version` has been set at build time. If not it assumes it's development. It may be better not to conflate version number with build type in which case we could add a separate build type. But first I wanted to see if the general idea desirable. * add log profile flag * add build variable
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zap development logger provides nicer console output as well as a few other different defaults for development.
To decide whether to use production or development it's checking if
Versionhas been set at build time. If not it assumes it's development. It may be
better not to conflate version number with build type in which case we could
add a separate build type. But first I wanted to see if the general idea
desirable.
Before
After