Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[component] clarifying lifecycle expectation #6535

Merged
merged 4 commits into from
Nov 16, 2022
Merged

[component] clarifying lifecycle expectation #6535

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9373844
Adding in docs on what is expected with Shutdown.
Nov 12, 2022
92463bd
Adding in chlog for clarifying component lifecycle
Nov 12, 2022
f9277c3
Update component/component.go
MovieStoreGuy Nov 15, 2022
d56e428
Remove changelog
Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions component/component.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ type Component interface {
// Shutdown is invoked during service shutdown. After Shutdown() is called, if the component
// accepted data in any way, it should not accept it anymore.
//
// This method must be safe to call:
// - without Start() having been called
// - if the component is in a shutdown state already
//
// If there are any background operations running by the component they must be aborted before
// this function returns. Remember that if you started any long-running background operations from
// the Start() method, those operations must be also cancelled. If there are any buffers in the
Expand Down