[component] clarifying lifecycle expectation #6535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 12, 2022 21:52
Intentionally adding in a changelog here since this can has significant impact on implemented components.
Codecov ReportBase: 91.33% // Head: 91.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6535 +/- ##
==========================================
- Coverage 91.33% 91.01% -0.32%
==========================================
Files 242 241 -1
Lines 13888 13885 -3
==========================================
- Hits 12684 12637 -47
- Misses 959 1008 +49
+ Partials 245 240 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I've include a change log for this PR since this documentation impacts all components of the project and contrib. |
codeboten
reviewed
Nov 14, 2022
Co-authored-by: Alex Boten <alex@boten.ca>
bogdandrutu
approved these changes
Nov 15, 2022
codeboten
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Extended the documentation of the component to include safe
Shutdownexpectations.Link to tracking Issue:
#6507
Testing:
N/A
Documentation:
N/A