Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Rename RegiserServer funcs to RegiserGRPCServer #6182

Merged

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Sep 29, 2022

p[log|trace|metric]otlp packages don't have grpc part in it anymore, so we need to add GRPC part to the related methods.

This change should've been landed in #6165

@dmitryax dmitryax requested review from a team and tigrannajaryan September 29, 2022 00:33
@dmitryax dmitryax force-pushed the deprecate-register-grpc-server branch from 097d457 to abaafdd Compare September 29, 2022 00:35
@dmitryax dmitryax changed the title [pdata] Rename RegiserServer func to RegiserGRPCServer [pdata] Rename RegiserServer funcs to RegiserGRPCServer Sep 29, 2022
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 91.77% // Head: 91.77% // No change to project coverage 👍

Coverage data is based on head (abaafdd) compared to base (c8871dc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6182   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         218      218           
  Lines       13358    13358           
=======================================
  Hits        12259    12259           
  Misses        870      870           
  Partials      229      229           
Impacted Files Coverage Δ
pdata/plog/plogotlp/logs.go 51.06% <100.00%> (ø)
pdata/pmetric/pmetricotlp/metrics.go 55.81% <100.00%> (ø)
pdata/ptrace/ptraceotlp/traces.go 51.06% <100.00%> (ø)
receiver/otlpreceiver/otlp.go 87.58% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu merged commit 8060037 into open-telemetry:main Sep 29, 2022
@dmitryax dmitryax deleted the deprecate-register-grpc-server branch September 29, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants