Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename marshall to marshal in all the occurrences #2977

Merged
merged 3 commits into from
Apr 21, 2021

Conversation

sincejune
Copy link
Contributor

Description:
Rename the usage of marshall to marshal which includes:

  • Variables with Marshaller or Unmarshaller
  • Methods with Marshall()
  • Files named with marshaller or unmarshaller

Fix comment #2973 (review) and #2973 (comment)

@sincejune sincejune requested a review from a team April 21, 2021 16:54
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CHANGELOG with both this change and previous change.

@sincejune
Copy link
Contributor Author

Update CHANGELOG.

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #2977 (e03b045) into main (e4a0713) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2977   +/-   ##
=======================================
  Coverage   91.64%   91.64%           
=======================================
  Files         312      312           
  Lines       15414    15414           
=======================================
  Hits        14126    14126           
  Misses        881      881           
  Partials      407      407           
Impacted Files Coverage Δ
exporter/kafkaexporter/otlp_marshaler.go 60.00% <ø> (ø)
receiver/kafkareceiver/jaeger_unmarshaler.go 100.00% <ø> (ø)
receiver/kafkareceiver/otlp_unmarshaler.go 100.00% <ø> (ø)
receiver/kafkareceiver/zipkin_unmarshaler.go 92.59% <ø> (ø)
receiver/otlpreceiver/marshal_jsonpb.go 12.61% <ø> (ø)
exporter/kafkaexporter/factory.go 100.00% <100.00%> (ø)
exporter/kafkaexporter/jaeger_marshaler.go 86.36% <100.00%> (ø)
exporter/kafkaexporter/kafka_exporter.go 100.00% <100.00%> (ø)
exporter/kafkaexporter/marshaler.go 100.00% <100.00%> (ø)
receiver/kafkareceiver/factory.go 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a0713...e03b045. Read the comment docs.

@sincejune
Copy link
Contributor Author

@bogdandrutu Would you able to re-run the test? It seems unrelated to my changes.

@bogdandrutu bogdandrutu merged commit 6661f03 into open-telemetry:main Apr 21, 2021
@sincejune sincejune deleted the rename-marshall-to-marshal branch April 22, 2021 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants