Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change With*Unmarshallers signatures #2973

Merged
merged 3 commits into from
Apr 21, 2021

Conversation

sincejune
Copy link
Contributor

@sincejune sincejune commented Apr 21, 2021

@sincejune sincejune requested a review from a team April 21, 2021 13:33
@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #2973 (b72494b) into main (13e4566) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2973   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         312      312           
  Lines       15404    15404           
=======================================
  Hits        14116    14116           
  Misses        881      881           
  Partials      407      407           
Impacted Files Coverage Δ
exporter/kafkaexporter/factory.go 100.00% <100.00%> (ø)
receiver/kafkareceiver/factory.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13e4566...b72494b. Read the comment docs.

@sincejune
Copy link
Contributor Author

The CI failure seems unrelated to my change. Could any try to re-run the CI?

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use 'Unmarshaler' (single 'l') on other places in the Collector while we use 'Unmarshallers' here. Both forms are valid English spelling but I think we should consider using a consistent spelling. Maybe this is a good PR to do so (if we want to use the single 'l' version at least)?

@sincejune sincejune changed the title Change With*Unmarshallers signatures; Rename variables in kafkaReceiv… Change With*Unmarshallers signatures Apr 21, 2021
@sincejune
Copy link
Contributor Author

This sounds good. I rollbacked my changes to the variables. I'd like to have another PR to rename Marshaller to Marshaler if you decide to do so.

(Also, please feel free to rollback my last commit if you choose the double ll version)

@bogdandrutu
Copy link
Member

@sincejune @mx-psi good catch, I would prefer the one "l" version (less spelling).

@bogdandrutu bogdandrutu merged commit e4a0713 into open-telemetry:main Apr 21, 2021
@sincejune sincejune deleted the kafka-signatures-change branch April 21, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka exporter/receiver change With*Unmarshallers signature
3 participants