Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hostmetricsreceiver (disk): Refactor to use metrics metadata #2406

Merged
merged 1 commit into from
Jan 29, 2021
Merged

hostmetricsreceiver (disk): Refactor to use metrics metadata #2406

merged 1 commit into from
Jan 29, 2021

Conversation

asuresh4
Copy link
Member

Depends on #2405

Refactor disk scraper to use metric metadata utilities.

@codecov
Copy link

codecov bot commented Jan 25, 2021 •
edited
Loading

Codecov Report

Merging #2406 (c192287) into main (bd70c80) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2406      +/-   ##
==========================================
- Coverage   91.93%   91.88%   -0.06%     
==========================================
  Files         269      268       -1     
  Lines       15278    15213      -65     
==========================================
- Hits        14046    13978      -68     
- Misses        854      857       +3     
  Partials      378      378
Impacted Files Coverage Δ
...nternal/scraper/diskscraper/disk_scraper_others.go 100.00% <100.00%> (ø)
...l/scraper/diskscraper/disk_scraper_others_linux.go 100.00% <100.00%> (ø)
exporter/exporterhelper/metricshelper.go 94.59% <0.00%> (-5.41%) ⬇️
internal/data/bytesid.go 76.92% <0.00%> (-4.03%) ⬇️
exporter/otlpexporter/otlp.go 71.79% <0.00%> (-2.57%) ⬇️
internal/data/traceid.go 92.30% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd70c80...c192287. Read the comment docs.

jrcamp
jrcamp approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@jrcamp jrcamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(other PR needs merging first)

Base automatically changed from master to main January 28, 2021 18:06
@asuresh4 asuresh4 marked this pull request as ready for review January 28, 2021 19:39
@asuresh4 asuresh4 requested a review from a team January 28, 2021 19:39
@asuresh4 asuresh4 mentioned this pull request Jan 29, 2021
Merged
@bogdandrutu bogdandrutu merged commit c5f2b25 into open-telemetry:main Jan 29, 2021
tigrannajaryan pushed a commit that referenced this pull request Feb 8, 2021
@asuresh4
hostmetricsreceiver: (network/paging/process) Refactor to use metrics…
73b8408 
… metadata (#2421)

Depends on #2406 

Refactor network, paging, process and processes scrapers to use metrics metadata utility.
This was referenced Mar 8, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrcamp jrcamp jrcamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asuresh4 @jrcamp @bogdandrutu