Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hostmetricsreceiver(filesystems): Refactor to use metrics metadata #2405

Merged
merged 2 commits into from
Jan 28, 2021

Conversation

asuresh4
Copy link
Member

Refactor to use metrics metadata utilities.

@asuresh4 asuresh4 requested a review from a team January 25, 2021 20:09
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #2405 (35f00e9) into master (c08f513) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2405      +/-   ##
==========================================
- Coverage   91.92%   91.91%   -0.01%     
==========================================
  Files         270      269       -1     
  Lines       15300    15283      -17     
==========================================
- Hits        14065    14048      -17     
- Misses        856      857       +1     
+ Partials      379      378       -1     
Impacted Files Coverage Δ
...eiver/internal/scraper/filesystemscraper/config.go 100.00% <100.00%> (ø)
...al/scraper/filesystemscraper/filesystem_scraper.go 100.00% <100.00%> (ø)
...raper/filesystemscraper/filesystem_scraper_unix.go 100.00% <100.00%> (ø)
internal/data/bytesid.go 76.92% <0.00%> (-4.03%) ⬇️
internal/processor/filterlog/filterlog.go 89.47% <0.00%> (+1.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c08f513...35f00e9. Read the comment docs.

receiver/hostmetricsreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/hostmetricsreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/hostmetricsreceiver/metadata.yaml Show resolved Hide resolved
@bogdandrutu
Copy link
Member

@jrcamp please let me know if I can merge this

@jrcamp
Copy link
Contributor

jrcamp commented Jan 28, 2021

@jrcamp please let me know if I can merge this

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants