[service] fix v0.2.0 to v0.3.0 conversion bug #12438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting headers from config schema v0.2.0 to v0.3.0 was causing a nil dereferencing issue by incorrectly setting the name/value pair to a nil pointer. Added a test in both the loading of the config in otelcol, as well as the migration code unit test. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
bogdandrutu
approved these changes
Feb 20, 2025
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
|
The failing test is blocked by #12437 |
bogdandrutu
reviewed
Feb 20, 2025
bogdandrutu
approved these changes
Feb 20, 2025
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12438 +/- ##
==========================================
- Coverage 92.19% 92.19% -0.01%
==========================================
Files 466 466
Lines 25325 25324 -1
==========================================
- Hits 23348 23347 -1
Misses 1577 1577
Partials 400 400 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting headers from config schema v0.2.0 to v0.3.0 was causing a nil dereferencing issue by incorrectly setting the name/value pair to a nil pointer. Added a test in both the loading of the config in otelcol, as well as the migration code unit test.
Fixes #12439