Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] fix bug in parsing service::telemetry configuration #12437

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

codeboten
Copy link
Contributor

Fixes #12436

Fixes open-telemetry#12436

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested a review from a team as a code owner February 19, 2025 22:26
@codeboten codeboten requested a review from mx-psi February 19, 2025 22:26
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten changed the title [service] fix bug in parsing otlp export configuration [service] fix bug in parsing service::telemetry configuration Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (d6d07c8) to head (05672ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12437   +/-   ##
=======================================
  Coverage   92.18%   92.19%           
=======================================
  Files         466      466           
  Lines       25306    25325   +19     
=======================================
+ Hits        23329    23348   +19     
  Misses       1577     1577           
  Partials      400      400           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten added this pull request to the merge queue Feb 20, 2025
Merged via the queue into open-telemetry:main with commit f024b0d Feb 20, 2025
55 checks passed
@codeboten codeboten deleted the codeboten/fix-12436 branch February 20, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

telemetry: parsing v0.2.0 configuration causes loss of default settings
2 participants