Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[builder] Support for --skip-new-go-module (#10098)" #10978

Conversation

codeboten
Copy link
Contributor

This reverts commit a0331ed.

@codeboten codeboten requested review from a team and atoulme August 27, 2024 13:25
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.69%. Comparing base (5963d44) to head (a24d56c).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/builder/internal/builder/main.go 62.50% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10978      +/-   ##
==========================================
- Coverage   91.86%   91.69%   -0.17%     
==========================================
  Files         411      411              
  Lines       19328    19294      -34     
==========================================
- Hits        17756    17692      -64     
- Misses       1221     1241      +20     
- Partials      351      361      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codeboten codeboten merged commit 79bef21 into open-telemetry:main Aug 27, 2024
50 of 66 checks passed
@codeboten codeboten deleted the codeboten/rollback-a0331ed86cf8f90316268d34e7e82550084c36ae branch August 27, 2024 14:07
@github-actions github-actions bot added this to the next release milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants