Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/builder] test error when creating new release #10975

Open
codeboten opened this issue Aug 27, 2024 · 3 comments
Open

[cmd/builder] test error when creating new release #10975

codeboten opened this issue Aug 27, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@codeboten
Copy link
Contributor

The following error occurs in the builder unit tests during the creation of the new release: https://github.com/open-telemetry/opentelemetry-collector/actions/runs/10571488001/job/29287662515?pr=10973

    --- FAIL: TestGetModules/Exporter_Not_in_Gomod (0.34s)
        main_test.go:651: 
            	Error Trace:	/home/runner/work/opentelemetry-collector/opentelemetry-collector/cmd/builder/internal/builder/main_test.go:651
            	Error:      	Received unexpected error:
            	            	failed to update go.mod: go subcommand failed with args '[mod tidy -compat=1.22]': exit status 1, error message: go: downloading go.opentelemetry.io/collector/confmap/provider/envprovider v0.108.0
            	            	go: downloading go.opentelemetry.io/collector/confmap/provider/fileprovider v0.108.0
            	            	go: downloading go.opentelemetry.io/collector/confmap/provider/httpprovider v0.108.0
            	            	go: downloading go.opentelemetry.io/collector/confmap/provider/httpsprovider v0.108.0
            	            	go: downloading go.opentelemetry.io/collector/confmap/provider/yamlprovider v0.108.0
            	            	go: downloading go.opentelemetry.io/collector/otelcol v0.108.0
            	            	go: go.opentelemetry.io/collector/confmap/provider/envprovider@v0.108.0: reading go.opentelemetry.io/collector/confmap/provider/envprovider/go.mod at revision confmap/provider/envprovider/v0.108.0: unknown revision confmap/provider/envprovider/v0.108.0

May be related to changes in #10098. @kristinapathak @mx-psi any help would be appreciated

@codeboten codeboten added bug Something isn't working release:blocker The issue must be resolved before cutting the next release labels Aug 27, 2024
@codeboten
Copy link
Contributor Author

Revert the change to unblock the release #10978, will leave the issue open to ensure the change is re-applied in a future release

@codeboten codeboten removed the release:blocker The issue must be resolved before cutting the next release label Aug 27, 2024
@codeboten
Copy link
Contributor Author

Removing the blocker label as the change has been reverted for now

@kristinapathak
Copy link
Contributor

I had a lot of problems with these unit tests - largely from breaking api changes in builder dependencies or new dependencies in the builder. This error was the result and honestly wasn't helpful in figuring out what the problem was. Given that these changes can happen at any time but don't cause the tests to fail until the default version is updated, I'm not sure what else to do here. With the current state of things, the tests are too brittle. The two options I see are:

  1. Give up on the --skip-new-go-module flag
  2. Reopen my PR with fewer tests and less coverage

CC @mx-psi @jaronoff97 @jmacd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants
@codeboten @kristinapathak and others