Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/builder] Generate replace directives when path is specified for provider #10851

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

czeltser
Copy link

Description

Fixes a bug where replace directives were not being generated when the path was specified for a provider in the builder configuration.

Testing

Unit tests were added. In addition, the change can be tested manually by building ocb with the changes, and running it on the following configuration:

dist:
  name: otelcol
  output_path: ./build

receivers:
  - gomod: go.opentelemetry.io/collector/receiver/otlpreceiver v0.99.0

exporters:
  - gomod: go.opentelemetry.io/collector/exporter/otlpexporter v0.99.0

providers:
  - gomod: foo.bar/dynamodbprovider v0.0.0
    path: ./confmap/dynamodbprovider

The generated go.mod contained the expected replace statement.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 29, 2024
@github-actions github-actions bot removed the Stale label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant