Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/builder] Generate replace directives when path is specified for provider #10202

Closed
wants to merge 2 commits into from

Conversation

czeltser
Copy link

@czeltser czeltser commented May 21, 2024

Description

Fixes a bug where replace directives were not being generated when the path was specified for a provider in the builder configuration.

Testing

Built ocb with the changes and ran it on the following configuration:

dist:
  name: otelcol
  output_path: ./build

receivers:
  - gomod: go.opentelemetry.io/collector/receiver/otlpreceiver v0.99.0

exporters:
  - gomod: go.opentelemetry.io/collector/exporter/otlpexporter v0.99.0

providers:
  - gomod: foo.bar/dynamodbprovider v0.0.0
    path: ./confmap/dynamodbprovider

The generated go.mod contained the expected replace statement.

@czeltser czeltser requested review from a team and djaglowski May 21, 2024 22:32
Copy link

linux-foundation-easycla bot commented May 21, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding some tests?

Copy link
Contributor

github-actions bot commented Jun 7, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 7, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jun 21, 2024
@czeltser
Copy link
Author

Do you mind adding some tests?

@bogdandrutu Sorry for the delay. I've re-opened the MR here with tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants