Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report exporter queue capacity as a metric #4902

Closed
william-tran opened this issue Feb 22, 2022 · 2 comments · Fixed by #5475
Closed

Report exporter queue capacity as a metric #4902

william-tran opened this issue Feb 22, 2022 · 2 comments · Fixed by #5475
Labels
good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up

Comments

@william-tran
Copy link

Is your feature request related to a problem? Please describe.
I'd like to see queue capacity as a metric so I can do derive queue % filled and alert on that without hardcoding the queue capacity into my prometheus query.

Describe the solution you'd like
Report otelcol_exporter_queue_capacity as a gauge

Describe alternatives you've considered
Hardcoding the capacity I've configured in dashboards and alerting, which can be error prone / tedious during tuning cycles of the exporter queue capacity and underlying file storage.
@jpkrohling
Copy link
Member

Sounds like a good idea.

Related to #4198

@william-tran william-tran mentioned this issue Mar 7, 2022
Closed
@bogdandrutu bogdandrutu added help wanted Good issue for contributors to OpenTelemetry Service to pick up good first issue Good for newcomers labels Apr 8, 2022
@fatsheep9146 fatsheep9146 mentioned this issue Jun 4, 2022
Merged
@fatsheep9146
Copy link
Contributor

fatsheep9146 commented Jun 4, 2022 •
edited
Loading

@bogdandrutu @jpkrohling I've tried to implement this, could you help review this? #5475

codeboten pushed a commit that referenced this issue Jul 19, 2022
@fatsheep9146
add metrics otelcol_exporter_queue_capacity (#5475)
389c047 
Fix #4902, add metric otelcol_exporter_queue_capacity

Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add metrics otelcol_exporter_queue_capacity fatsheep9146/opentelemetry-collector
4 participants
@jpkrohling @william-tran @bogdandrutu @fatsheep9146