-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how component developers can add metrics to their code #4198
Comments
@djaglowski FYI. |
@jpkrohling we already expose "MeterProvider" in the CreateParams (I know is a no-op) so components can start using that (will be some time until we will enable them though). |
This is at the top of my todo and will work on it soon. |
I created a PR as a first step towards defining the pattern we want to recommend to component developers. I would like to ask everyone in this thread to take a look at it and share their thoughts. |
@jpkrohling Do you mind sharing the PR link again? I can't seem to find the PR which talks about adding metrics to a component. I do see PR on checklist for components but can't find one which talks about adding more metrics. |
The PR I mentioned was a WIP to start a discussion but was ultimately closed. You can look at components like the load balancing exporter for an example of how to add metrics to a component, but we do not have official guidelines yet, as we are blocked by the availability of the OpenTelemetry Go SDK. |
Fixes open-telemetry#4198 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Once the move from OC to OpenTelemetry SDK happens (#816), we need to enhance the contributing guideline with information on how component developers can add metrics to their own code. As part of this task, it should be evaluated whether it makes sense to add similar docs to the collector's documentation on the website.
The text was updated successfully, but these errors were encountered: