Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies Logz.io exporter #4386

Merged
merged 8 commits into from
Jul 30, 2021
Merged

Update dependencies Logz.io exporter #4386

merged 8 commits into from
Jul 30, 2021

Conversation

yotamloe
Copy link
Contributor

@yotamloe yotamloe commented Jul 28, 2021 •
edited
Loading

Description:
Logz.io exporter upgrade 🚀
Update versions of jaeger-logzio -> 1.0.3, and logzio-go -> 1.0.2
Link to tracking Issue:
#3736 and #3702
Testing:
No tests added
From logzioexporter directory:
go test -v -covermode=atomic -race
output:

PASS
coverage: 96.6% of statements

Documentation:
No documentation added

@yotamloe yotamloe requested review from a team and djaglowski July 28, 2021 11:02
bogdandrutu
bogdandrutu requested changes Jul 28, 2021
View reviewed changes
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this into upgrade deps/ add functionality

@yotamloe yotamloe changed the title Update dependencies (jaeger-logzio, logzio-go) + Add queue management Update dependencies (jaeger-logzio, logzio-go) Logz.io exporter Jul 28, 2021
@yotamloe yotamloe changed the title Update dependencies (jaeger-logzio, logzio-go) Logz.io exporter Update dependencies Logz.io exporter Jul 28, 2021
@yotamloe
Copy link
Contributor Author

@bogdandrutu Thanks for your update.
I will open a new PR for new functionalities as soon as this one will be merged

@bogdandrutu
Copy link
Member

Please rebase

@bogdandrutu
Copy link
Member

There are some issues, all checks are failing

@yotamloe
Copy link
Contributor Author

@bogdandrutu Thanks a lot for your help. I suspect that func TestEndToEnd(t *testing.T) this test of prometheusexecreceiver is failing regardless of the changes I made in this PR... I ran it independently from the most updated collector version (not including my PR) and it keep failing. How can we progress?

@tigrannajaryan tigrannajaryan merged commit 36a7da6 into open-telemetry:main Jul 30, 2021
@yotamloe yotamloe mentioned this pull request Aug 2, 2021
Merged
bogdandrutu pushed a commit that referenced this pull request Aug 3, 2021
Revert "Update dependencies Logz.io exporter (#4386)"
4e41e41 
This reverts commit 36a7da6.
@bogdandrutu bogdandrutu mentioned this pull request Aug 3, 2021
Closed
@mx-psi mx-psi mentioned this pull request Sep 24, 2021
Closed
hex1848 pushed a commit to hex1848/opentelemetry-collector-contrib that referenced this pull request Jun 2, 2022
[test] cleanup in otlp_test (open-telemetry#4386)
3f43d69 
The `createSingleSpanTrace` makes a single testdata.GenerateTracesOneSpan() call, no point in having a separate function for this.
@yotamloe yotamloe mentioned this pull request May 9, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski

Assignees

@bogdandrutu bogdandrutu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yotamloe @bogdandrutu @tigrannajaryan