Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jaeger legacy and kubeletstats metric receivers #401

Merged

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Jul 6, 2020

Description:
The jaeger legacy and kubeletstats receivers were not updated to the latest change in the ReceiverFactoryOld interface open-telemetry/opentelemetry-collector@2f6d603

The jaeger legacy and kubeletstats receivers were not updated to the latest change in the ReceiverFactoryOld interface open-telemetry/opentelemetry-collector@2f6d603
@dmitryax dmitryax requested a review from a team July 6, 2020 23:34
@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #401 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   84.08%   84.10%   +0.02%     
==========================================
  Files         181      181              
  Lines        9680     9680              
==========================================
+ Hits         8139     8141       +2     
+ Misses       1208     1207       -1     
+ Partials      333      332       -1     
Flag Coverage Δ
#integration 63.22% <ø> (ø)
#unit 83.89% <ø> (+0.02%) ⬆️
Impacted Files Coverage Δ
receiver/jaegerlegacyreceiver/factory.go 93.65% <ø> (ø)
receiver/kubeletstatsreceiver/factory.go 100.00% <ø> (ø)
receiver/carbonreceiver/transport/tcp_server.go 67.61% <0.00%> (+1.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4ad0a4...c3571e2. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 3ae0f00 into open-telemetry:master Jul 7, 2020
wyTrivail referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 13, 2020
The jaeger legacy and kubeletstats receivers were not updated to the latest change in the ReceiverFactoryOld interface open-telemetry/opentelemetry-collector@2f6d603
mxiamxia referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 22, 2020
This is for consistency reasons and to ensure configuration parameters
match directory structure.
bogdandrutu pushed a commit that referenced this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants