Fix jaeger legacy and kubeletstats metric receivers (#401)

The jaeger legacy and kubeletstats receivers were not updated to the latest change in the ReceiverFactoryOld interface open-telemetry/opentelemetry-collector@2f6d603
mxiamxia · Jul 13, 2020 · 4a3706c · 4a3706c
1 parent 65b656a
commit 4a3706c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/receiver/jaegerlegacyreceiver/factory.go b/receiver/jaegerlegacyreceiver/factory.go
@@ -135,6 +135,7 @@ func (f *Factory) CreateTraceReceiver(
 
 // CreateMetricsReceiver creates a metrics receiver based on provided config.
 func (f *Factory) CreateMetricsReceiver(
+	ctx context.Context,
 	logger *zap.Logger,
 	cfg configmodels.Receiver,
 	consumer consumer.MetricsConsumer,

diff --git a/receiver/jaegerlegacyreceiver/factory_test.go b/receiver/jaegerlegacyreceiver/factory_test.go
@@ -50,7 +50,7 @@ func TestCreateReceiver(t *testing.T) {
 	assert.NoError(t, err, "receiver creation failed")
 	assert.NotNil(t, tReceiver, "receiver creation failed")
 
-	mReceiver, err := factory.CreateMetricsReceiver(zap.NewNop(), cfg, nil)
+	mReceiver, err := factory.CreateMetricsReceiver(context.Background(), zap.NewNop(), cfg, nil)
 	assert.Equal(t, err, configerror.ErrDataTypeIsNotSupported)
 	assert.Nil(t, mReceiver)
 }

diff --git a/receiver/kubeletstatsreceiver/factory.go b/receiver/kubeletstatsreceiver/factory.go
@@ -67,6 +67,7 @@ func (f *Factory) CreateTraceReceiver(
 }
 
 func (f *Factory) CreateMetricsReceiver(
+	ctx context.Context,
 	logger *zap.Logger,
 	cfg configmodels.Receiver,
 	consumer consumer.MetricsConsumerOld,

diff --git a/receiver/kubeletstatsreceiver/factory_test.go b/receiver/kubeletstatsreceiver/factory_test.go
@@ -56,6 +56,7 @@ func TestCreateTraceReceiver(t *testing.T) {
 func TestCreateMetricsReceiver(t *testing.T) {
 	factory := &Factory{}
 	metricsReceiver, err := factory.CreateMetricsReceiver(
+		context.Background(),
 		zap.NewNop(),
 		tlsConfig(),
 		&testbed.MockMetricConsumer{},
@@ -73,7 +74,7 @@ func TestFactoryBadAuthType(t *testing.T) {
 			},
 		},
 	}
-	_, err := factory.CreateMetricsReceiver(zap.NewNop(), cfg, &testbed.MockMetricConsumer{})
+	_, err := factory.CreateMetricsReceiver(context.Background(), zap.NewNop(), cfg, &testbed.MockMetricConsumer{})
 	require.Error(t, err)
 }