Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GCP exporters to v0.48.2 #35366

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Update GCP exporters to v0.48.2 #35366

merged 7 commits into from
Oct 7, 2024

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Sep 23, 2024 •
edited
Loading

Description:
This updates the GCP dependencies to v0.48.2. Full release notes for this release are available at https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.48.2

Link to tracking Issue:

Testing: Downstream unit/integration tests

Documentation: n/a

Fixes #35206

@damemi damemi requested review from dashpole, jsuereth and a team as code owners September 23, 2024 16:24
@github-actions github-actions bot added cmd/otelcontribcol otelcontribcol command exporter/googlecloud exporter/googlemanagedprometheus Google Managed Prometheus exporter labels Sep 23, 2024
@github-actions github-actions bot requested review from aabmass, psx95 and punya September 23, 2024 16:24
@dashpole dashpole added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 23, 2024
@dashpole
Copy link
Contributor

looks like the GMP exporter needs to be updated. Also remember to mark the exporters mutating. That should be using exporterhelper.WithCapabilities(consumer.Capabilities{MutatesData: true})

@github-actions github-actions bot added connector/datadog exporter/datadog Datadog components processor/resourcedetection Resource detection processor labels Sep 23, 2024
songy23
songy23 reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go.mod/go.sum deps changes detected, please run "make gotidy" and commit the changes in this PR.

songy23
songy23 reviewed Sep 23, 2024
View reviewed changes
.chloggen/gcp-0482.yaml Outdated Show resolved Hide resolved
@songy23 songy23 added dependencies Pull requests that update a dependency file and removed Skip Changelog PRs that do not require a CHANGELOG.md entry labels Sep 23, 2024
@dashpole dashpole added the ready to merge Code review completed; ready to merge by maintainers label Sep 24, 2024
codeboten
codeboten approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase and it should be good to merge after

@songy23 songy23 removed the ready to merge Code review completed; ready to merge by maintainers label Sep 26, 2024
@dashpole
Copy link
Contributor

dashpole commented Oct 4, 2024

@damemi please rebase when you get the chance.

@mx-psi mx-psi merged commit 3fa7d8d into open-telemetry:main Oct 7, 2024
155 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 7, 2024
@damemi
Copy link
Contributor Author

damemi commented Oct 7, 2024

Rebased, thanks!

shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Oct 7, 2024
@damemi @shalper2
Update GCP exporters to v0.48.2 (open-telemetry#35366)
26d8918 
**Description:**
This updates the GCP dependencies to v0.48.2. Full release notes for
this release are available at
https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.48.2

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** Downstream unit/integration tests

**Documentation:** n/a

Fixes
open-telemetry#35206
ghost pushed a commit to sematext/opentelemetry-collector-contrib that referenced this pull request Oct 9, 2024
@damemi @AkhigbeEromo
Update GCP exporters to v0.48.2 (open-telemetry#35366)
84ff0e9 
**Description:**
This updates the GCP dependencies to v0.48.2. Full release notes for
this release are available at
https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.48.2

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** Downstream unit/integration tests

**Documentation:** n/a

Fixes
open-telemetry#35206
This was referenced Oct 9, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@dashpole dashpole dashpole approved these changes

@codeboten codeboten codeboten approved these changes

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@aabmass aabmass Awaiting requested review from aabmass

@psx95 psx95 Awaiting requested review from psx95

@punya punya Awaiting requested review from punya

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@ankitpatel96 ankitpatel96 Awaiting requested review from ankitpatel96

@dineshg13 dineshg13 Awaiting requested review from dineshg13

@liustanley liustanley Awaiting requested review from liustanley

@mackjmr mackjmr Awaiting requested review from mackjmr

Assignees

@codeboten codeboten

Labels
cmd/otelcontribcol otelcontribcol command connector/datadog dependencies Pull requests that update a dependency file exporter/datadog Datadog components exporter/googlecloud exporter/googlemanagedprometheus Google Managed Prometheus exporter processor/resourcedetection Resource detection processor
Projects
None yet
Milestone
v0.112.0
Development

Successfully merging this pull request may close these issues.

[exporter/googlecloud]: Timeout doesn't seem to be respected for logs
5 participants
@damemi @dashpole @codeboten @songy23 @mx-psi