Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/googlecloud]: Timeout doesn't seem to be respected for logs #35206

Closed
BinaryFissionGames opened this issue Sep 16, 2024 · 5 comments · Fixed by #35366
Closed

[exporter/googlecloud]: Timeout doesn't seem to be respected for logs #35206

BinaryFissionGames opened this issue Sep 16, 2024 · 5 comments · Fixed by #35366
Assignees
Labels
bug Something isn't working exporter/googlecloud

Comments

@BinaryFissionGames
Copy link
Contributor

Component(s)

exporter/googlecloud

What happened?

The timeout parameter doesn't seem to matter for sending logs. I think it's entirely ignored.

You can see in the factory that the timeout is passed to the constructor function for the traces/metrics exporter, but the logs exporter does not get the timeout:

logsExporter, err := collector.NewGoogleCloudLogsExporter(ctx, eCfg.Config, params.TelemetrySettings.Logger, params.BuildInfo.Version)

Collector version

v0.108.0

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@BinaryFissionGames BinaryFissionGames added bug Something isn't working needs triage New item requiring triage labels Sep 16, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dashpole
Copy link
Contributor

@damemi can you take a look at this if you have time?

@dashpole dashpole removed the needs triage New item requiring triage label Sep 16, 2024
@damemi
Copy link
Contributor

damemi commented Sep 16, 2024

cc @braydonk do you know if there's a specific reason not to have the timeout passed to the logging exporter? Or could we just add that?

@braydonk
Copy link
Contributor

@damemi Just looks like an oversight to me. Should be able to pass in a timeout to the logs exporter and then use that when creating contexts for the loggingClient calls, similar to how it's done in the metric and trace exporters.

@damemi
Copy link
Contributor

damemi commented Sep 19, 2024

This will be included in the next release of our exporter with GoogleCloudPlatform/opentelemetry-operations-go#894 merged

@mx-psi mx-psi closed this as completed in 3fa7d8d Oct 7, 2024
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this issue Oct 7, 2024
**Description:**
This updates the GCP dependencies to v0.48.2. Full release notes for
this release are available at
https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.48.2

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** Downstream unit/integration tests

**Documentation:** n/a

Fixes
open-telemetry#35206
Eromosele-SM pushed a commit to sematext/opentelemetry-collector-contrib that referenced this issue Oct 9, 2024
**Description:**
This updates the GCP dependencies to v0.48.2. Full release notes for
this release are available at
https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.48.2

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** Downstream unit/integration tests

**Documentation:** n/a

Fixes
open-telemetry#35206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exporter/googlecloud
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants