-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/googlecloud]: Timeout doesn't seem to be respected for logs #35206
Comments
@damemi can you take a look at this if you have time? |
cc @braydonk do you know if there's a specific reason not to have the timeout passed to the logging exporter? Or could we just add that? |
@damemi Just looks like an oversight to me. Should be able to pass in a timeout to the logs exporter and then use that when creating contexts for the |
This will be included in the next release of our exporter with GoogleCloudPlatform/opentelemetry-operations-go#894 merged |
**Description:** This updates the GCP dependencies to v0.48.2. Full release notes for this release are available at https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.48.2 **Link to tracking Issue:** <Issue number if applicable> **Testing:** Downstream unit/integration tests **Documentation:** n/a Fixes open-telemetry#35206
**Description:** This updates the GCP dependencies to v0.48.2. Full release notes for this release are available at https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.48.2 **Link to tracking Issue:** <Issue number if applicable> **Testing:** Downstream unit/integration tests **Documentation:** n/a Fixes open-telemetry#35206
Component(s)
exporter/googlecloud
What happened?
The timeout parameter doesn't seem to matter for sending logs. I think it's entirely ignored.
You can see in the factory that the timeout is passed to the constructor function for the traces/metrics exporter, but the logs exporter does not get the timeout:
opentelemetry-collector-contrib/exporter/googlecloudexporter/factory.go
Line 58 in 1b03346
Collector version
v0.108.0
Environment information
No response
OpenTelemetry Collector configuration
No response
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: