carbonexporter: migrate to latest semconv version #35351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirm there is no risk. The semconv attributes' value have been compared using go-otel-semconv-comparator resulting in 0 diffs. |
crobert-1
approved these changes
Sep 24, 2024
codeboten
approved these changes
Sep 25, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
Description: The version of semconv is upgraded from v1.6.1 to newer versions This upgrade is trivial. The semconv attributes' value have been compared using [go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator) resulting in 0 (relevant) diffs: - conventions.AttributeServiceName="service.name" on both versions Link to tracking Issue: open-telemetry#22095 Testing: Tests passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The version of semconv is upgraded from v1.6.1 to newer versions
This upgrade is trivial. The semconv attributes' value have been compared using go-otel-semconv-comparator resulting in 0 (relevant) diffs:
Link to tracking Issue: #22095
Testing: Tests passed