Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to latest semconv version and ensure we regularly update going forward #22095

Open
2 tasks
mx-psi opened this issue May 19, 2023 · 6 comments
Open
2 tasks

Migrate to latest semconv version and ensure we regularly update going forward #22095

mx-psi opened this issue May 19, 2023 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium

Comments

@mx-psi
Copy link
Member

mx-psi commented May 19, 2023

Component(s)

No response

Describe the issue you're reporting

As highlighted by @sumo-drosiek on #18740 (comment), we use a lot of different versions of go.opentelemetry.io/collector/semconv across this repository.

We would want to:

  • Bump existing uses to the latest specification version
  • Ensure that we regularly update semconv

For the latter, I am not sure what is the best way to do this; one option is to have an internal package that re-exports symbols from a fixed semconv package and just update this one. This package could be autogenerated to keep it updated.
@mx-psi mx-psi added enhancement New feature or request good first issue Good for newcomers priority:p2 Medium labels May 19, 2023
@mx-psi mx-psi mentioned this issue May 19, 2023
Merged
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • issue: Github issue template generation code needs this to generate the corresponding labels.

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 19, 2023
@mx-psi mx-psi removed the Stale label Jul 19, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • issue: Github issue template generation code needs this to generate the corresponding labels.

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Sep 18, 2023
@mx-psi mx-psi added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Sep 18, 2023
@mx-psi
Copy link
Member Author

mx-psi commented Apr 4, 2024

We can do this in two steps: first we update until 1.20.0, then we deal with the HTTP semantic conventions upgrade

@narcis96
Copy link
Contributor

Hello! I’m interested in taking on this issue as my first contribution to OpenTelemetry. I see it’s labeled as a 'good first issue,' and I’d love to get started. Please let me know your thoughts.

@mx-psi
Copy link
Member Author

mx-psi commented Sep 12, 2024

@narcis96 You can pick a component from the following list:

cmd/telemetrygen
connector/datadogconnector
connector/exceptionsconnector
connector/servicegraphconnector
connector/spanmetricsconnector
exporter/alertmanagerexporter
exporter/alibabacloudlogserviceexporter
exporter/awsemfexporter
exporter/awsxrayexporter
exporter/azuremonitorexporter
exporter/carbonexporter
exporter/clickhouseexporter
exporter/datadogexporter
exporter/instanaexporter
exporter/kafkaexporter
exporter/loadbalancingexporter
exporter/logzioexporter
exporter/mezmoexporter
exporter/pulsarexporter
exporter/sentryexporter
exporter/signalfxexporter
exporter/splunkhecexporter
exporter/tencentcloudlogserviceexporter
extension/opampextension
internal/coreinternal
internal/exp
internal/filter
internal/metadataproviders
internal/splunk
pkg/translator
processor/attributesprocessor
processor/k8sattributesprocessor
processor/probabilisticsamplerprocessor
processor/resourcedetectionprocessor
processor/spanprocessor
processor/sumologicprocessor
receiver/awsecscontainermetricsreceiver
receiver/awsfirehosereceiver
receiver/awsxrayreceiver
receiver/azureeventhubreceiver
receiver/datadogreceiver
receiver/dockerstatsreceiver
receiver/hostmetricsreceiver
receiver/jaegerreceiver
receiver/k8sclusterreceiver
receiver/k8seventsreceiver
receiver/k8sobjectsreceiver
receiver/kafkareceiver
receiver/kubeletstatsreceiver
receiver/prometheusreceiver
receiver/pulsarreceiver
receiver/receivercreator
receiver/sapmreceiver
receiver/skywalkingreceiver
receiver/splunkhecreceiver
receiver/zipkinreceiver
testbed/tests

and update all imports that refer to go.opentelemetry.io/collector/semconv with a version below v1.18.0 to the highest version you can. This would etiher be v1.18.0 or, in some other cases, v1.27.0. Please start with a single component so that the PR is small and we can give you quick feedback!

@narcis96
Copy link
Contributor

thanks ! will do that.

@narcis96 narcis96 mentioned this issue Sep 13, 2024
Merged
mx-psi pushed a commit that referenced this issue Sep 13, 2024
@narcis96
awsfirehosereceiver: migrate to latest semconv version (#35172)
33ce26b 
**Description:** The version of semconv is upgraded from to v1.6.1 to
v1.27.0

**Link to tracking Issue:**
#22095

**Testing:** Tests passed
This was referenced Sep 17, 2024
Closed
Merged
Open
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
TylerHelmuth pushed a commit that referenced this issue Sep 19, 2024
@narcis96
kubeletstatsreceiver: migrate to latest semconv version (#35273)
07ee9e4 
Description: The version of semconv is upgraded from v1.6.1 to v1.27.0

Link to tracking Issue:
#22095

Testing: Tests passed
dmitryax pushed a commit to dmitryax/opentelemetry-collector-contrib that referenced this issue Sep 19, 2024
@narcis96 @dmitryax
kubeletstatsreceiver: migrate to latest semconv version (open-telemet…
58cd9b8 
…ry#35273)

Description: The version of semconv is upgraded from v1.6.1 to v1.27.0

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
alertmanagerexporter: migrate to latest semconv version (open-telemet…
2a8d7fd 
…ry#35341)

Description: The version of semconv is upgraded from v1.6.1 to v1.27.0

This is a trivial migration. semconv usage inside component:

- conventions.AttributeServiceName="service.name" on both versions

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
mezmoexporter: migrate to latest semconv version (open-telemetry#35370)
828c885 
Description: The version of semconv is upgraded from v1.6.1 to v1.27.0

This is a trivial upgrade because only the test file has been modified.
The semconv attributes' value have been compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator)
resulting in 0 diffs.

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
opampextension: migrate to newer semconv version (open-telemetry#35393)
3f320b6 
Description: The version of semconv is upgraded from v1.18.0 to v1.27.0

This is a trivial upgrade. The semconv attributes' value have been
compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator).
All attributes used by this component have the same value in both
versions.

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @codeboten @jriguera
datadogconnector: migrate to latest semconv version (open-telemetry#3…
8ee8eca 
…5269)

Description: The version of semconv is upgraded from to v1.17.0 and
v1.5.0 to v1.27.0

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed

Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
splunkhecreceiver: migrate to latest semconv version (open-telemetry#…
2c4cd12 
…35315)

Description: The version of semconv is upgraded from v1.6.1 to v1.27.0

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
spanmetricsconnector: migrate to latest semconv version (open-telemet…
72cd4b7 
…ry#35272)

Description: The version of semconv is upgraded from v1.6.1 to v1.27.0

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
servicegraphconnector: migrate to semconv version 1.25.0 (open-teleme…
eed5826 
…try#35271)

Description: The version of semconv is upgraded from v1.13.0 and v1.9.0
to v1.25.0

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
kafkareceiver: migrate to latest semconv version (open-telemetry#35240)
ddba981 
Description: The version of semconv is upgraded from to v1.6.1 to
v1.27.0

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
tencentcloudlogserviceexporter: migrate to newer semconv version (ope…
f6cb7d1 
…n-telemetry#35392)

Description: The version of semconv is upgraded from v1.6.1 to v1.27.0

This is a trivial upgrade. The semconv attributes' value have been
compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator).
All attributes used by this component have the same value in both
versions.

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
splunkhecexporter: migrate to newer semconv version (open-telemetry#3…
2b7cd0f 
…5391)

Description: The version of semconv is upgraded from v1.6.1 to v1.27.0

This is a trivial upgrade. The semconv attributes' value have been
compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator).
All attributes used by this component have the same value in both
versions.

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
jaegerreceiver: migrate to latest semconv version (open-telemetry#35237)
9efafed 
Description: The version of semconv is upgraded from to v1.6.1 to
v1.27.0

The semconv attributes' value have been compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator)
resulting in relevant 0 diffs.

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
sentryexporter: migrate to newer semconv version (open-telemetry#35389)
332e586 
Description: The version of semconv is upgraded from v1.6.1 to v1.18.0

This is a trivial upgrade. The semconv attributes' value have been
compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator).
All attributes used by this component have the same value in both
versions.

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
logzioexporter: migrate to latest semconv version (open-telemetry#35369)
9de7678 
Description: The version of semconv is upgraded from v1.6.1 to v1.27.0

This is a trivial upgrade because only the test file has been modified.
The semconv attributes' value have been compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator)
resulting in 0 diffs.

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
signalfxexporter: migrate to newer semconv version (open-telemetry#35390
a0dd55e 
)

Description: The version of semconv is upgraded from v1.6.1 to v1.26.0

This is a trivial upgrade. The semconv attributes' value have been
compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator).
All attributes used by this component have the same value in both
versions.

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
loadbalancingexporter: migrate to latest semconv version (open-teleme…
d2ecb14 
…try#35368)

Description: The version of semconv is upgraded from v1.6.1 and v1.9.0
to v1.27.0

This is a trivial upgrade. The semconv attributes' value have been
compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator)
resulting in 0 diffs.

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
azuremonitorexporter: migrate to newer semconv versions (open-telemet…
aa95e21 
…ry#35350)

Description: The version of semconv is upgraded from v1.6.1 to newer
versions

The semconv attributes' value have been compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator)
resulting in 0 diffs:
- 1.7.0 version has been used if the no newer version contains all
attributes used by the file (all attributes of 1.6.1 exists and have the
same value inside 1.7.0)
- 1.12.0 version has been used if the no newer version contains all
attributes used by the file (all attributes of 1.6.1 exists and have the
same value inside 1.12.0)
- 1.27.0 version has been used if only if the file does _not_ contain
_AttributeMessagingMessageID_ and _AttributeMessagingKafkaMessageKey_:

<img width="798" alt="otel_comp"
src="https://github.com/user-attachments/assets/5e9befc7-80f9-4758-a357-0dec82373a11">

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
awsemfexporter: migrate to latest semconv version (open-telemetry#35343)
b9da76d 
Description: The version of semconv is upgraded from v1.6.1 to v1.27.0

This is a trivial migration. semconv usage inside component:

- conventions.AttributeServiceName="service.name" on both versions
- conventions.AttributeServiceNamespace="service.namespace" on both
versions

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
awsxrayexporter: migrate to latest semconv version (open-telemetry#35347
48168ea 
)

Description: The version of semconv is upgraded from v1.6.1 to v1.12.0

This is a trivial migration. The semconv attributes' value have been
compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator)
resulting in 0 diffs:

- all attributes of 1.6.1 exists and have the same value inside 1.12.0

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
exceptionsconnector: migrate to latest semconv version (open-telemetr…
ee481d5 
…y#35270)

Description: The version of semconv is upgraded from v1.6.1 and v1.18.0
to v1.27.0

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
clickhouseexporter: migrate to latest semconv version (open-telemetry…
f5c64fe 
…#35355)

Description: The version of semconv is upgraded from v1.18.0 to v1.27.0

This is a trivial migration. The semconv attributes' value have been
compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator)
resulting in 0 diffs (all attributes of 1.18.0 exists with the same
value inside 1.27.0)

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
carbonexporter: migrate to latest semconv version (open-telemetry#35351)
4aae9af 
Description: The version of semconv is upgraded from v1.6.1 to newer
versions

This upgrade is trivial. The semconv attributes' value have been
compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator)
resulting in 0 (relevant) diffs:

- conventions.AttributeServiceName="service.name" on both versions

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@narcis96 @jriguera
zipkinreceiver: migrate to latest semconv version (open-telemetry#35340)
62049b0 
Description: The version of semconv is upgraded from v1.6.1 to v1.12.0

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
mx-psi pushed a commit that referenced this issue Oct 7, 2024
@narcis96
internal/ + pkg/ : migrate to latest semconv version (#35241)
7fa8f92 
Description: The version of semconv is upgraded to v1.27.0

The semconv attributes' value have been compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator)
resulting in 0 diffs:
- 1.12.0 version has been used if the no newer version contains all
attributes used by the file (all attributes of 1.6.1 exists and have the
same value inside 1.12.0)
- 1.27.0 version has been used if only if the file does not contain
AttributeMessagingMessageID and AttributeMessagingKafkaMessageKey:

Link to tracking Issue:
#22095

Testing: Tests passed
Eromosele-SM pushed a commit to sematext/opentelemetry-collector-contrib that referenced this issue Oct 9, 2024
@narcis96 @AkhigbeEromo
internal/ + pkg/ : migrate to latest semconv version (open-telemetry#…
93f0b35 
…35241)

Description: The version of semconv is upgraded to v1.27.0

The semconv attributes' value have been compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator)
resulting in 0 diffs:
- 1.12.0 version has been used if the no newer version contains all
attributes used by the file (all attributes of 1.6.1 exists and have the
same value inside 1.12.0)
- 1.27.0 version has been used if only if the file does not contain
AttributeMessagingMessageID and AttributeMessagingKafkaMessageKey:

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
@narcis96 narcis96 mentioned this issue Oct 21, 2024
Closed
6 tasks
mx-psi pushed a commit that referenced this issue Oct 24, 2024
@narcis96
azureeventhubreceiver: migrate to newer semconv version (#35601)
99be4ac 
Description: The version of semconv is upgraded from v1.13.0 to v1.27.0

This is a trivial upgrade. The semconv attributes' value have been
compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator).
All attributes used by this component have the same value in both
versions.

Link to tracking Issue:
#22095

Testing: Tests passed
mx-psi pushed a commit that referenced this issue Oct 24, 2024
@narcis96
awsecscontainermetricsreceiver: migrate to newer semconv version (#35599
e925145 
)

Description: The version of semconv is upgraded from v1.6.1 to v1.21.0

This is a trivial upgrade. The semconv attributes' value have been
compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator).
All attributes used by this component have the same value in both
versions.

Link to tracking Issue:
#22095

Testing: Tests passed
mx-psi pushed a commit that referenced this issue Oct 24, 2024
@narcis96
dockerstatsreceiver: migrate to newer semconv version (#35603)
90da89e 
Description: The version of semconv is upgraded from v1.6.1 to v1.27.0

This is a trivial upgrade. The semconv attributes' value have been
compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator).
All attributes used by this component have the same value in both
versions.

Link to tracking Issue:
#22095

Testing: Tests passed
MovieStoreGuy pushed a commit that referenced this issue Nov 10, 2024
@narcis96
awsxrayreceiver: migrate to newer semconv version (#35600)
4b322db 
Description: The version of semconv is upgraded from v1.6.1 to v1.18.0

This is a trivial upgrade. The semconv attributes' value have been
compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator).
All attributes used by this component have the same value in both
versions.

Link to tracking Issue:
#22095

Testing: Tests passed
pull bot pushed a commit to abaguas/opentelemetry-collector-contrib that referenced this issue Nov 11, 2024
@narcis96 @pull
awsxrayreceiver: migrate to newer semconv version (open-telemetry#35600)
b3df28c 
Description: The version of semconv is upgraded from v1.6.1 to v1.18.0

This is a trivial upgrade. The semconv attributes' value have been
compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator).
All attributes used by this component have the same value in both
versions.

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mx-psi @narcis96