Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/sijms/go-ora/v2 to v2.8.21 #35247

Closed
wants to merge 3 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 17, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/sijms/go-ora/v2 v2.8.19 -> v2.8.21 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

sijms/go-ora (github.com/sijms/go-ora/v2)

v2.8.21: : Fix recall Query and Exec for same Command Object

Compare Source

v2.8.20: : Multiple issue fixing

Compare Source


Configuration

📅 Schedule: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added dependencies Pull requests that update a dependency file renovatebot labels Sep 17, 2024
@renovate renovate bot requested a review from a team September 17, 2024 15:56
@crobert-1
Copy link
Member

crobert-1 commented Sep 17, 2024

Looks like our linter is catching some lint failures in the sjims/go-ora/v2 dependency here:

Error: /home/runner/go/pkg/mod/github.com/sijms/go-ora/v2@v2.8.21/converters/other_types.go:81:25: 2147483648 (untyped int constant) overflows int
Error: /home/runner/go/pkg/mod/github.com/sijms/go-ora/v2@v2.8.21/converters/other_types.go:102:23: 2147483648 (untyped int constant) overflows int
Error: /home/runner/go/pkg/mod/github.com/sijms/go-ora/v2@v2.8.21/converters/other_types.go:108:21: 2147483648 (untyped int constant) overflows int
Error: /home/runner/go/pkg/mod/github.com/sijms/go-ora/v2@v2.8.21/converters/other_types.go:1[16](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10906799019/job/30269344525?pr=35247#step:7:17):21: 2147483648 (untyped int constant) overflows int

Edit: I've filed sijms/go-ora#597 upstream for this.

@crobert-1
Copy link
Member

sijms/go-ora#597 will be fixed in the next release of sjims/go-ora/v2, I think it's safe to skip this minor version bump and just wait for the next one.

@crobert-1 crobert-1 closed this Sep 17, 2024
Copy link
Contributor Author

renovate bot commented Sep 17, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (v2.8.21). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/github.com-sijms-go-ora-v2-2.x branch September 17, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/otelcontribcol otelcontribcol command dependencies Pull requests that update a dependency file internal/sqlquery receiver/oracledb receiver/sqlquery SQL query receiver receiver/sqlserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants