Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lint] Untyped int constant overflows int #597

Closed
crobert-1 opened this issue Sep 17, 2024 · 2 comments
Closed

[lint] Untyped int constant overflows int #597

crobert-1 opened this issue Sep 17, 2024 · 2 comments
Labels

Comments

@crobert-1
Copy link

Hello, golang linter is picking up potential integer overflows in this package:

Error: /home/runner/go/pkg/mod/github.com/sijms/go-ora/v2@v2.8.21/converters/other_types.go:81:25: 2147483648 (untyped int constant) overflows int
Error: /home/runner/go/pkg/mod/github.com/sijms/go-ora/v2@v2.8.21/converters/other_types.go:102:23: 2147483648 (untyped int constant) overflows int
Error: /home/runner/go/pkg/mod/github.com/sijms/go-ora/v2@v2.8.21/converters/other_types.go:108:21: 2147483648 (untyped int constant) overflows int
Error: /home/runner/go/pkg/mod/github.com/sijms/go-ora/v2@v2.8.21/converters/other_types.go:1[16](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10906799019/job/30269344525?pr=35247#step:7:17):21: 2147483648 (untyped int constant) overflows in

This is not a new issue, but is being hit due to golang's linter now checking for this. We hit these failures when attempting to upgrade the sjims/go-ora/v2 dependency in the OpenTelemetry Collector here.

@sijms
Copy link
Owner

sijms commented Sep 17, 2024

Hi @crobert-1
this file is no longer use. I will remove it next release

@sijms
Copy link
Owner

sijms commented Oct 10, 2024

fixed in next release v2.8.22

@sijms sijms added the fixed label Oct 10, 2024
@sijms sijms closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants