fix Azure receiver not azure china

[mo-silent]

Description:

Add azure china to complete AzureMonitor Receiver

Link to tracking Issue:
#34315

[crobert-1]

Hello @mo-silent, can you please update the README as well to show this is a valid option for the cloud configuration option?

It would be good to add some kind of simple test for this as well.

[mo-silent]

Hi @crobert-1
Sure. I've updated README to add a valid option for cloud configuration options.

[crobert-1]

Would you be able to add a simple test for this? (Sorry if you were still working on it, just commenting to make sure we didn't miss it.)

[mo-silent]

Hi @crobert-1
I'm not adding a new function. I just supplemented the Azure Cloud type by adding Azure China Cloud. So I don't think additional test code is needed, the existing test code uses defaultCloud, which is azureCloud. Again, there is no separate test case written for azureGovernmentCloud in the original test code.

[crobert-1]

Hi @crobert-1 I'm not adding a new function. I just supplemented the Azure Cloud type by adding Azure China Cloud. So I don't think additional test code is needed, the existing test code uses defaultCloud, which is azureCloud. Again, there is no separate test case written for azureGovernmentCloud in the original test code.

I was thinking it would be good to have a test where the configuration is set to the new configuration option AzureChinaCloud, and then show that the *arm.ClientOptions object returned by getArmClientOptions is properly set to use the AzureChinaCloud. Let me know if that isn't possible, I had assumed it was a relatively simple test to add, but I might be missing something.

[mo-silent]

Hi @crobert-1
I see what you mean. Have been added, called TestAzureScraperClientOptions test functions, and contains AzureChinaCloud, AzureCloud, AzureGovernmentCloud, the three cloud configuration options for the test cases.

[crobert-1]

Thanks for adding the test @mo-silent!

From CI/CD:

azuremonitorreceiver/scraper_test.go:7: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)
	"context"
azuremonitorreceiver/scraper_test.go:18: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)
level=info msg="File cache stats: 17 entries of total size 95.8KiB"
level=info msg="Memory: 57 samples, avg is 198.3MB, max is 377.3MB"
level=info msg="Execution took 5.59690985s"
	"path/filepath"
	"reflect"
	"strings"
	"sync"
	"testing"
make[2]: *** [../../Makefile.Common:199: lint] Error 1
make[1]: *** [Makefile:179: receiver/azuremonitorreceiver] Error 2

This should be able to be resolved by running make gofmt

[mo-silent]

Hi @crobert-1
Well. make gofmt has been executed.

[crobert-1]

Thanks for resolving @mo-silent!

[codeboten]

Thanks @mo-silent!

[codeboten]

Would be good to add support for "AzureGermanCloud" as well, i'll open a follow up issue