Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/azuremonitor] add support for AzureGermanCloud #34614

Closed
codeboten opened this issue Aug 12, 2024 · 4 comments
Closed

[receiver/azuremonitor] add support for AzureGermanCloud #34614

codeboten opened this issue Aug 12, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed receiver/azuremonitor

Comments

@codeboten
Copy link
Contributor

As listed here, there's an AzureGermanCloud option as well. It would be good to add support for that.

          Would be good to add support for "AzureGermanCloud" as well, i'll open a follow up issue

Originally posted by @codeboten in #34402 (comment)

Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@codeboten codeboten added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 12, 2024
@mahadzaryab1
Copy link

@codeboten I can work on this!

@mahadzaryab1
Copy link

mahadzaryab1 commented Aug 25, 2024

@codeboten It looks like the Go Azure SDK doesn't have configuration for AzureGermanCloud (https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azcore/cloud/cloud.go#L9-L22). Opened an issue at Azure/azure-sdk-for-go#23371 to address this.

@codeboten
Copy link
Contributor Author

Thanks for following up @mahadzaryab1, it looks like it's not needed as that's no longer supported by microsoft https://learn.microsoft.com/en-us/previous-versions/azure/germany/germany-welcome

@codeboten codeboten closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed receiver/azuremonitor
Projects
None yet
Development

No branches or pull requests

2 participants