Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[connector/otlpjson] Move stability to alpha #34253

Merged
merged 2 commits into from
Jul 26, 2024
Merged

[connector/otlpjson] Move stability to alpha #34253

merged 2 commits into from
Jul 26, 2024

Conversation

ChrsMark
Copy link
Member

Description:

This is the 3rd PR for the new otlpjson connector (#34208). Moves its stability to alpha.

Link to tracking Issue: #34208 #34239 #34249

Testing: ~

Documentation: Updated

@github-actions github-actions bot requested a review from djaglowski July 25, 2024 14:36
@ChrsMark ChrsMark force-pushed the otlpjsoncon_alpha branch from 5b4b6f8 to 3f7c88b Compare July 25, 2024 14:36
@ChrsMark ChrsMark marked this pull request as ready for review July 25, 2024 15:01
@ChrsMark ChrsMark requested a review from a team July 25, 2024 15:01
@ChrsMark ChrsMark force-pushed the otlpjsoncon_alpha branch from 3f7c88b to 57325b3 Compare July 25, 2024 15:02
songy23
songy23 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml too

djaglowski
djaglowski reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed the config.go code was a placeholder, but if we don't need any custom validation I believe we can delete it.

@ChrsMark
Copy link
Member Author

I assumed the config.go code was a placeholder, but if we don't need any custom validation I believe we can delete it.

👍🏽 . As proposed at #34249 (comment) for now there is no exposed config and we can go with plain pass-through approach. We can iterate on this if we have specific requests/use-cases.
I have removed the Validate().

ChrsMark added 2 commits July 26, 2024 10:14
@ChrsMark
[connector/otlpjson] Move stability to alpha
fd8b9c1 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
remove empty config validation
189e50c 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark force-pushed the otlpjsoncon_alpha branch from a725127 to 189e50c Compare July 26, 2024 07:14
@ChrsMark ChrsMark mentioned this pull request Jul 26, 2024
Closed
@djaglowski djaglowski merged commit 98ae65b into open-telemetry:main Jul 26, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

@songy23 songy23 songy23 approved these changes

Assignees

@atoulme atoulme

Labels
cmd/otelcontribcol otelcontribcol command connector/otlpjson
Projects
None yet
Milestone
v0.106.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrsMark @djaglowski @songy23 @atoulme