Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add otlpjson connector to contrib #611

Closed
wants to merge 1 commit into from

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jul 26, 2024

@ChrsMark ChrsMark requested review from a team and TylerHelmuth July 26, 2024 08:49
@ChrsMark
Copy link
Member Author

I see some tests are failing 🤔 . Do we need to wait for a release of the contrib repo to take place before adding the component here?

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrsMark right this module wont be available until contrib is released. What I usually end up doing when I'm the release manager is to pull this kind of change into the new version as part of the release process.

Pinging @songy23 as the release manager for the next release.

@@ -208,6 +208,7 @@ connectors:
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/connector/datadogconnector v0.105.0
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/connector/exceptionsconnector v0.105.0
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/connector/grafanacloudconnector v0.105.0
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/connector/otlpjsonconnector v0.105.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrsMark
Copy link
Member Author

Closing as it will be added by #615 (comment). Thank's @songy23!

@ChrsMark ChrsMark closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants