WIP: prometheusremotewrite: Introduce pluggable conversion architecture #32684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Aneurysm9,
bertysentry,
dashpole and
rapphil
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
arve/pluggable-api
branch
from
ec22656
to
f6b5ed8
Compare
|
Closing since I've found a better approach, see comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Expose the
pkg/translator/prometheusremotewrite.prometheusConvertertype, as an implementation of new interfacepkg/translator/prometheusremotewrite.MetricsConverter.The purpose of the
MetricsConverterinterface is to facilitate converters for Prometheus compatible systems such as Grafana Mimir/Thanos/Cortex, with partially shared implementation (theConvertMetricsandaddResourceTargetInfofunctions). The conversion methods for the different metric types are not shared, in order to achieve optimal performance.Link to tracking Issue: #32666
Testing:
Documentation: