-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/translator/prometheusremotewrite] Introduce API based around hash based metrics identifiers #32666
Comments
Pinging code owners:
%s See Adding Labels via Comments if you do not have permissions to add labels yourself. |
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> I noticed the output of a recent comment made by the `github-actions` bot had an extra `%s` in its output when pinging code owners on new issues. This is unnecessary. Example links: #32666 (comment) #32723 (comment)
Please note that I dropped the proposal of generating the |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
Component(s)
pkg/translator/prometheusremotewrite
Is your feature request related to a problem? Please describe.
There is a remaining performance related problem with the
translator/prometheusremotewrite
module: The new API that I introduced based around hash based metric identifiers is hidden behind theFromMetrics
shim, and as a result the full performance benefits are not reaped.Describe the solution you'd like
The solution we (Grafana Mimir and Prometheus maintainers) would like is to expose the
prometheusConverter
type withintranslator/prometheusremotewrite
, which is currently hidden behind the wrappingFromMetrics
function. Let it expose two methods:Benchmarks
Benchmarking stats PrometheusConverter.FromMetrics vs. FromMetrics wrapper function
Describe alternatives you've considered
Additional context
In conjunction with my previous PR, converting from string based metrics identifiers to hash based ones, @Aneurysm9 requested that I open an issue with a proposal for exposing the new converter type. In an OTel call, @Aneurysm9 also suggested that the proposal include a framework for converting directly to other formats than Prometheus.
Regarding the latter point, I've arrived at an approach where I transform the
prometheusremotewrite
sources to the Mimir equivalent mainly through a tool called gopatch. This means there's not much need for facilitation in opentelemetry-collector-contrib sources.The text was updated successfully, but these errors were encountered: