Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal/sqlquery] use errors.Join instead of multierr #31768

Merged
merged 3 commits into from
Mar 15, 2024
Merged

[internal/sqlquery] use errors.Join instead of multierr #31768

merged 3 commits into from
Mar 15, 2024

Conversation

led0nk
Copy link
Contributor

@led0nk led0nk commented Mar 14, 2024

Description:

Link to tracking Issue:

Testing:

Documentation:

@led0nk led0nk requested a review from dmitryax as a code owner March 14, 2024 19:07
@led0nk led0nk requested a review from a team March 14, 2024 19:07
@github-actions github-actions bot requested a review from crobert-1 March 14, 2024 19:08
@frzifus frzifus added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 14, 2024
crobert-1
crobert-1 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

songy23
songy23 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs make crosslink

@led0nk
Copy link
Contributor Author

led0nk commented Mar 14, 2024

done :)

@codeboten codeboten merged commit 3351c9d into open-telemetry:main Mar 15, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 15, 2024
@TylerHelmuth TylerHelmuth mentioned this pull request Mar 15, 2024
Merged
@led0nk led0nk deleted the replace-multierr branch March 27, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@songy23 songy23 songy23 approved these changes

@frzifus frzifus frzifus approved these changes

@codeboten codeboten codeboten approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees

@MovieStoreGuy MovieStoreGuy

Labels
internal/sqlquery Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.97.0
Development

Successfully merging this pull request may close these issues.
6 participants
@led0nk @codeboten @frzifus @songy23 @crobert-1 @MovieStoreGuy