Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go 1.20 errors.Join instead of go.uber.org/multierr #25121

Closed
mx-psi opened this issue Aug 9, 2023 · 12 comments
Closed

Use Go 1.20 errors.Join instead of go.uber.org/multierr #25121

mx-psi opened this issue Aug 9, 2023 · 12 comments
Assignees
@shivanshuraj1333
Labels
ci-cd CI, CD, testing, build issues closed as inactive Contribfest enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed priority:p2 Medium Stale

Comments

@mx-psi
Copy link
Member

mx-psi commented Aug 9, 2023 •
edited
Loading

Component(s)

No response

Describe the issue you're reporting

Go 1.20 includes new builtin error joining support that can replace the usage of go.uber.org/multierr. We should switch to using these and ban the usage of go.uber.org/multierr via depguard (same as this).

Counterpart of open-telemetry/opentelemetry-collector#8210.

This is blocked by #25116
@mx-psi mx-psi added enhancement New feature or request good first issue Good for newcomers priority:p2 Medium ci-cd CI, CD, testing, build issues on hold This is blocked by another PR/issue labels Aug 9, 2023
@bryan-aguilar
Copy link
Contributor

Would we prefer to see this per component or one big search and replace PR?

@mx-psi
Copy link
Member Author

mx-psi commented Aug 11, 2023

Would we prefer to see this per component or one big search and replace PR?

I guess it is up to whoever takes this, my experience is that per component (or at least not everything at once) is a bit less frustrating for contributors given the churn of conflicts

@shivanshuraj1333
Copy link
Member

shivanshuraj1333 commented Aug 11, 2023 •
edited
Loading

I can work on this, @mx-psi kindly assign, would do once the blocker PR is merged.

This was referenced Aug 13, 2023
Merged
Merged
dmitryax pushed a commit that referenced this issue Aug 14, 2023
@shivanshuraj1333
[chore] [clickhouseexporter] use errors.Join instead of go.uber.org/m…
977eae4 
…ultierr (#25183)

Part of:
#25121
dmitryax pushed a commit that referenced this issue Aug 14, 2023
@shivanshuraj1333
[chore] migrate all the files under connector to use errors.Join (#25184
07db6e6 
)

Related to
#25121
@shivanshuraj1333 shivanshuraj1333 mentioned this issue Aug 14, 2023
Merged
djaglowski pushed a commit that referenced this issue Aug 14, 2023
@shivanshuraj1333
[chore] Migrate all aws receviers to use errors.Join (#25185)
e136bfd 
Related to
#25121
@gord02
Copy link
Contributor

gord02 commented Aug 30, 2023

Hello everyone. Are there any other components that need to migrate over to the new built-in error support?

@mx-psi mx-psi removed the on hold This is blocked by another PR/issue label Aug 31, 2023
@mx-psi
Copy link
Member Author

mx-psi commented Aug 31, 2023

Hey @gord02! There are still components that you can migrate, I think e.g. @shivanshu1333 has not gotten started with processors and most exporters are not done either.

Please see open-telemetry/opentelemetry-collector#8225 (comment) when making a PR: if replacing multierr.Append prefer appending to a slice and then using errors.Join on the slice!

@bagmeg
Copy link
Contributor

bagmeg commented Oct 14, 2023

Hi I'm interested in working on it. Can i work on it?

@mx-psi
Copy link
Member Author

mx-psi commented Oct 16, 2023

Sure, feel free to open a PR @bagmeg :)

@bagmeg bagmeg mentioned this issue Oct 18, 2023
Merged
dmitryax pushed a commit that referenced this issue Oct 19, 2023
@bagmeg
[chore][exporter/fileexporter] use errors.Join instead of go.uber.org…
be81ae7 
…/multierr (#27835)

**Description:** fileexporter: use errors.Join instead of go.uber.org/multierr

**Link to tracking Issue:** #25121
@bagmeg bagmeg mentioned this issue Oct 19, 2023
Merged
TylerHelmuth pushed a commit that referenced this issue Oct 19, 2023
@bagmeg
[chore][exporter/elasticsearchexporter] use errors.Join instead of go…
cbe5e71 
….uber.org/multierr (#27857)

**Description:** 
use errors.Join instead of go.uber.org/multierr

**Link to tracking Issue:** <Issue number if applicable>
#25121 

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
martin-majlis-s1 pushed a commit to scalyr/opentelemetry-collector-contrib that referenced this issue Oct 20, 2023
@bagmeg @martin-majlis-s1
[chore][exporter/fileexporter] use errors.Join instead of go.uber.org…
8154201 
…/multierr (open-telemetry#27835)

**Description:** fileexporter: use errors.Join instead of go.uber.org/multierr

**Link to tracking Issue:** open-telemetry#25121
martin-majlis-s1 pushed a commit to scalyr/opentelemetry-collector-contrib that referenced this issue Oct 20, 2023
@bagmeg @martin-majlis-s1
[chore][exporter/elasticsearchexporter] use errors.Join instead of go…
e0a68fa 
….uber.org/multierr (open-telemetry#27857)

**Description:** 
use errors.Join instead of go.uber.org/multierr

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#25121 

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
@bagmeg bagmeg mentioned this issue Oct 20, 2023
Merged
mx-psi pushed a commit that referenced this issue Oct 23, 2023
@bagmeg
[chore][exporter/datadogexporter] use errors.Join instead of go.uber.…
e027722 
…org/multierr (#27888)

**Description:** 
use errors.Join instead of go.uber.org/multierr

**Link to tracking Issue:** <Issue number if applicable>
#25121 

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
@bagmeg bagmeg mentioned this issue Oct 23, 2023
Merged
@github-actions github-actions bot added the Stale label Feb 12, 2024
@frzifus frzifus removed the Stale label Mar 14, 2024
@led0nk led0nk mentioned this issue Mar 14, 2024
Merged
codeboten pushed a commit that referenced this issue Mar 15, 2024
@led0nk
[internal/sqlquery] use errors.Join instead of multierr (#31768)
3351c9d 
**Link to tracking Issue:** 
- #25121
@led0nk led0nk mentioned this issue Mar 15, 2024
Merged
dmitryax pushed a commit that referenced this issue Mar 15, 2024
@led0nk
[receiver/rabbitmqreceiver] use errors.Join instead of multierr (#31779)
d82d6f5 
**Link to tracking Issue:** 
- #25121
@bagmeg bagmeg mentioned this issue Apr 18, 2024
Merged
@TylerHelmuth TylerHelmuth mentioned this issue May 3, 2024
Merged
jpkrohling added a commit that referenced this issue May 7, 2024
@bagmeg @jpkrohling
[chore][receiver/datadogreceiver] use errors.Join instead of go.uber.…
b066838 
…org/multierr (#32509)

**Description:** <Describe what has changed.>
use errors.Join instead of go.uber.org/multierr

**Link to tracking Issue:** <Issue number if applicable>
#25121 

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@argonavist
Copy link
Contributor

Hi I'm interested in helping with this, may I?

@bryan-aguilar
Copy link
Contributor

Feel free to send PRs for components which are still using multierr to join errors.

@argonavist argonavist mentioned this issue May 7, 2024
Merged
andrzej-stencel pushed a commit that referenced this issue May 8, 2024
[exporter/syslogexporter] use errors.Join instead of go.uber.org/mult…
03ebf97 
…ierr (#32925)

**Description:** 
syslogexporter: use errors.Join instead of go.uber.org/multierr

**Link to tracking Issue:** 

[#25121](#25121)

**Testing:** 

**Documentation:**
@argonavist argonavist mentioned this issue May 10, 2024
Merged
@rogercoll rogercoll mentioned this issue May 14, 2024
Merged
codeboten pushed a commit that referenced this issue May 14, 2024
[chore][receiver/chronyreceiver] use errors.Join instead of go.uber.o…
3c608d0 
…rg/multierr (#32979)

chronyreceiver: use errors.Join instead of go.uber.org/multierr

**Link to tracking Issue:** 

[#25121](#25121)
andrzej-stencel pushed a commit that referenced this issue May 16, 2024
@rogercoll
[receiver/elasticsearch] remove multierr from elasticsearch receiver (#…
4b9a237 
…33052)

**Description:** <Describe what has changed.>
Replace multierr in favor of errors.Join

**Link to tracking Issue:** 

#25121

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jul 8, 2024
@crobert-1 crobert-1 mentioned this issue Jul 10, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2024
@bagmeg bagmeg removed their assignment Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivanshuraj1333 shivanshuraj1333

Labels
ci-cd CI, CD, testing, build issues closed as inactive Contribfest enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed priority:p2 Medium Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@mx-psi @frzifus @TylerHelmuth @argonavist @shivanshuraj1333 @bryan-aguilar @gord02 @bagmeg