-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all github.com/datadog packages #31398
Update all github.com/datadog packages #31398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing on behalf of datadog-receiver. I'll defer to @mx-psi for the other ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need a changelog?
This PR doesn't have any user facing changes, so no changelog is needed. |
Please rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding until next RC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for the AttributesTranslator changes
Updates all datadog dependencies to the psuedo version from the [otel/backport](https://github.com/DataDog/datadog-agent/tree/otel/backport) branch and addresses the following breaking changes: - DataDog/datadog-agent#22729 - DataDog/datadog-agent#22809 Functional changes: - Initialize `OTLPReceiver.AttributesTranslator` in traces pipeline, and set in trace agent configs - Metrics client is no longer initalized in `createTracesToTracesConnector` because there is no initialization of the trace agent in the trace to trace connector - `InitializeMetricClient` can be called multiple times now that the singleton is gone - `metrics_client.go` implements `Distribution` by calling `Histogram` for the same implementation - `metrics_client.go` adds placeholders for statsd methods that are not applicable to our collector components
Description:
Updates all datadog dependencies to the psuedo version from the otel/backport branch and addresses the following breaking changes:
Functional changes:
OTLPReceiver.AttributesTranslator
in traces pipeline, and set in trace agent configscreateTracesToTracesConnector
because there is no initialization of the trace agent in the trace to trace connectorInitializeMetricClient
can be called multiple times now that the singleton is gonemetrics_client.go
implementsDistribution
by callingHistogram
for the same implementationmetrics_client.go
adds placeholders for statsd methods that are not applicable to our collector componentsLink to tracking Issue:
Testing:
Documentation:
This PR doesn't have any user facing changes, so no changelog is needed.