Skip to content

Conversation

ahmed-mez
Copy link
Contributor

@ahmed-mez ahmed-mez commented Feb 13, 2024

What does this PR do?

AIT-9796

Get rid of the timing singleton in the trace-agent.

Motivation

Same as #22729

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

The new-e2e tests for APM cover this. The list of expected metrics has been extended in this PR to include more metrics emitted by the timing package.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@ahmed-mez ahmed-mez added changelog/no-changelog team/agent-apm trace-agent [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card qa/done QA done before merge and regressions are covered by tests labels Feb 13, 2024
@ahmed-mez ahmed-mez added this to the 7.52.0 milestone Feb 13, 2024
@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2024

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: deaad50b-cc5d-48b2-9077-ab1f3c65f222
Baseline: 21f3b52
Comparison: 330b292
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -1.33 [-7.88, +5.22]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otel_to_otel_logs ingress throughput +0.57 [-0.04, +1.19]
process_agent_standard_check_with_stats memory utilization +0.35 [+0.30, +0.40]
trace_agent_json ingress throughput +0.01 [-0.01, +0.03]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00]
trace_agent_msgpack ingress throughput -0.01 [-0.02, +0.01]
idle memory utilization -0.07 [-0.11, -0.02]
uds_dogstatsd_to_api_cpu % cpu utilization -0.09 [-1.53, +1.35]
process_agent_real_time_mode memory utilization -0.23 [-0.28, -0.19]
process_agent_standard_check memory utilization -0.52 [-0.57, -0.46]
file_tree memory utilization -0.64 [-0.75, -0.53]
tcp_syslog_to_blackhole ingress throughput -1.22 [-1.28, -1.16]
file_to_blackhole % cpu utilization -1.33 [-7.88, +5.22]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@ahmed-mez ahmed-mez marked this pull request as ready for review February 13, 2024 12:22
@ahmed-mez ahmed-mez requested review from a team as code owners February 13, 2024 12:22
@ahmed-mez ahmed-mez requested a review from liustanley February 13, 2024 12:22
@ahmed-mez
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 13, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Feb 13, 2024

🚂 MergeQueue

Added to the queue.

This build is next! (estimated merge in less than 48m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 8ac852b into main Feb 13, 2024
@dd-mergequeue dd-mergequeue bot deleted the ahmed/timing branch February 13, 2024 17:41
knusbaum pushed a commit that referenced this pull request Feb 28, 2024
trace-agent: get rid of the timing singleton
codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Feb 29, 2024
Updates all datadog dependencies to the psuedo version from the
[otel/backport](https://github.com/DataDog/datadog-agent/tree/otel/backport)
branch and addresses the following breaking changes:
- DataDog/datadog-agent#22729
- DataDog/datadog-agent#22809

Functional changes:
- Initialize `OTLPReceiver.AttributesTranslator` in traces pipeline, and
set in trace agent configs
- Metrics client is no longer initalized in
`createTracesToTracesConnector` because there is no initialization of
the trace agent in the trace to trace connector
- `InitializeMetricClient` can be called multiple times now that the
singleton is gone
- `metrics_client.go` implements `Distribution` by calling `Histogram`
for the same implementation
- `metrics_client.go` adds placeholders for statsd methods that are not
applicable to our collector components
knusbaum pushed a commit that referenced this pull request Mar 1, 2024
trace-agent: get rid of the timing singleton
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
Updates all datadog dependencies to the psuedo version from the
[otel/backport](https://github.com/DataDog/datadog-agent/tree/otel/backport)
branch and addresses the following breaking changes:
- DataDog/datadog-agent#22729
- DataDog/datadog-agent#22809

Functional changes:
- Initialize `OTLPReceiver.AttributesTranslator` in traces pipeline, and
set in trace agent configs
- Metrics client is no longer initalized in
`createTracesToTracesConnector` because there is no initialization of
the trace agent in the trace to trace connector
- `InitializeMetricClient` can be called multiple times now that the
singleton is gone
- `metrics_client.go` implements `Distribution` by calling `Histogram`
for the same implementation
- `metrics_client.go` adds placeholders for statsd methods that are not
applicable to our collector components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card mergequeue-status: done qa/done QA done before merge and regressions are covered by tests team/agent-apm trace-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants