[telemetrygen] Fix case where root CAs should inherit from host environment #31250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Juliaj can you review this? |
mx-psi
approved these changes
Feb 14, 2024
bryan-aguilar
approved these changes
Feb 14, 2024
|
@mx-psi, @AlexDCraig , the changes look good! |
|
@mx-psi @bryan-aguilar @dmitryax Are we good to proceed? |
|
@AlexDCraig, weird, I thought I put the |
bryan-aguilar
added
the
ready to merge
TylerHelmuth
approved these changes
Feb 21, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…onment (open-telemetry#31250) **Description:** Adding TLS configuration to telemetrygen made it so that providing root CA information is mandatory. This is for the case when you are generating CAs and using them to sign certificates. In the case where the CA that signed the certificate is a known trusted CA, we shouldn't have to provide its CA certificate. This PR fixes this problem by allowing the code to pull its CA pool from the host environment when CAs are not explicitly supplied. **Link to tracking Issue:** [github.com/open-telemetry/issues/31191](open-telemetry#31191) **Testing:** Generate metrics, logs, traces against http and grpc endpoints with legitimate certificates **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding TLS configuration to telemetrygen made it so that providing root CA information is mandatory. This is for the case when you are generating CAs and using them to sign certificates. In the case where the CA that signed the certificate is a known trusted CA, we shouldn't have to provide its CA certificate. This PR fixes this problem by allowing the code to pull its CA pool from the host environment when CAs are not explicitly supplied.
Link to tracking Issue: github.com/open-telemetry/opentelemetry-collector-contrib/issues/31191
Testing: Generate metrics, logs, traces against http and grpc endpoints with legitimate certificates
Documentation: