[chore] Use gotestsum wrapper for go tests #31163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
force-pushed
the
mx-psi/gotestsum
branch
from
cb5570e
to
eba95dc
Compare
|
cc @open-telemetry/collector-contrib-approvers does this seem like a good idea to you? The main benefit from this PR is that the output format is nicer and it makes tests logs a bit more manageable. We could also introduce rerun on failed (see https://github.com/gotestyourself/gotestsum#documentation for more details) |
andrzej-stencel
approved these changes
Feb 13, 2024
I can't say with certainty that someone out there is not using this, but we don't use it on CI AFAICT, and we could add it back if needed by using |
TylerHelmuth
pushed a commit
that referenced
this pull request
Feb 14, 2024
**Description:** Re-runs failed unit tests automatically. Follow up to #31163 This re-runs the tests once if there are less than 10 total test failures. This should speed up development, but it comes with the risk of missing real issues. I think given the current situation our CI is in this is acceptable, but I assume this PR is going to be controversial :) One improvement would be to keep this but auto-generate Github issues when a test fails and then passes on main's CI. **Link to tracking Issue:** Relates to #30880 (does not speed up individual tests but reduces the number of attempts to be made)
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Use https://github.com/gotestyourself/gotestsum for running tests. This PR only adds the wrapper. A future PR could add `--rerun-fails`, but since that is, I presume, more controversial, I want to start just with the basics, which already improves readability. **Link to tracking Issue:** Relates to open-telemetry#30880
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** Re-runs failed unit tests automatically. Follow up to open-telemetry#31163 This re-runs the tests once if there are less than 10 total test failures. This should speed up development, but it comes with the risk of missing real issues. I think given the current situation our CI is in this is acceptable, but I assume this PR is going to be controversial :) One improvement would be to keep this but auto-generate Github issues when a test fails and then passes on main's CI. **Link to tracking Issue:** Relates to open-telemetry#30880 (does not speed up individual tests but reduces the number of attempts to be made)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use https://github.com/gotestyourself/gotestsum for running tests.
This PR only adds the wrapper. A future PR could add
--rerun-fails, but since that is, I presume, more controversial, I want to start just with the basics, which already improves readability.Link to tracking Issue: Relates to #30880