[exporter/signalfx] Fix memory leak on shutdown #30887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added failing connector test as freq of #31005 |
|
Tests have passed 6 times in a row, I believe this is ready for review. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
atoulme
approved these changes
Feb 29, 2024
atoulme
added
the
ready to merge
dmitryax
approved these changes
Feb 29, 2024
exporter/signalfxexporter/internal/correlation/correlation_test.go
Outdated
Show resolved
Hide resolved
dmitryax
added a commit
to dmitryax/opentelemetry-collector-contrib
that referenced
this pull request
Mar 4, 2024
dmitryax
added a commit
that referenced
this pull request
Mar 4, 2024
…1541) This reverts commit 494bdb8. The change introduced a flaky test, making the build unstable. Reverting for now. Examples: - https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8135561006/job/22233883822 - https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8131615657/job/22221154096 - https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8118428574/job/22192725196
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> `goleak` was detecting leaking goroutines in tests, this attempts to resolve. I found what appeared to be a couple races but can't reproduce locally so I'll run CI a few times to ensure this works as expected. Changes in PR: 1. Add correlation client Shutdown function that blocks on the waitgroup. This is the main fix of this PR that should fix the leaking goroutines. 2. Re-organize the shutdown process of the apm client correlation test suite to properly synchronize the shutting down process. 3. Fix typo 4. Add goleak checks to exporter/signalfx/internal/correlation` and `exporter/signalfx/internal/apm/correlations` **Link to tracking Issue:** <Issue number if applicable> Resolves open-telemetry#30864 open-telemetry#30438 **Testing:** <Describe what testing was performed and which tests were added.> All existing and added tests should be passing. Since this has only failed in CI I'm going to try to run it a few times before marking as ready for review.
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…ry#30887)" (open-telemetry#31541) This reverts commit 494bdb8. The change introduced a flaky test, making the build unstable. Reverting for now. Examples: - https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8135561006/job/22233883822 - https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8131615657/job/22221154096 - https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8118428574/job/22192725196
mx-psi
pushed a commit
that referenced
this pull request
Mar 25, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Changes in PR: 1. Add correlation client Shutdown function that blocks on the waitgroup. This is the main fix of this PR that should fix the leaking goroutines. 2. Re-organize the shutdown process of the apm client correlation test suite to properly synchronize the shutting down process. 3. Fix typo 4. Only block request sender until context is cancelled. The request processor is shutdown when the context is cancelled, so this would result in `Shutdown` waiting forever, since the request would never be processed. 5. Enable goleak in some more packages. **Note**: This is contains the exact same contents as #30887, but change number 4 is new, and should resolve the test issue the original PR was causing. **Link to tracking Issue:** Resolves #30864 #30438 **Testing:** <Describe what testing was performed and which tests were added.> All existing tests are passing, as well as added goleak checks. I'm going to run this a number of times to try to help ensure it's not flaky anymore.
|
@crobert-1 any idea which version introduced this memory leak? |
Not exactly sure, but it's been present since at least |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
goleakwas detecting leaking goroutines in tests, this attempts to resolve. I found what appeared to be a couple races but can't reproduce locally so I'll run CI a few times to ensure this works as expected.Changes in PR:
andexporter/signalfx/internal/apm/correlations`Link to tracking Issue:
Resolves #30864
#30438
Testing:
All existing and added tests should be passing. Since this has only failed in CI I'm going to try to run it a few times before marking as ready for review.