[pkg/ottl] adding code for double converter #27457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
There was a problem hiding this comment.
@gord02 this looks good. Also updateottl/ottlfuncs/functions.go with the new factory and add a ottl/ottlfuncs/README entry.
|
@gord02 when you're ready for a full review please take the PR out of draft. |
|
Hello @TylerHelmuth. Will this PR need a changelog entry or can it be skipped? |
|
@gord02 it will need an |
|
Does anyone have any suggestions on how to resolve the failing 'integration-tests' check? |
TylerHelmuth
approved these changes
Oct 12, 2023
TylerHelmuth
added
the
ready to merge
dmitryax
approved these changes
Oct 19, 2023
4 tasks
martin-majlis-s1
pushed a commit
to scalyr/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2023
**Description:** Adding a Double converter to pkg/ottl **Link to tracking Issue:** closes open-telemetry#22056
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
**Description:** Adding a Double converter to pkg/ottl **Link to tracking Issue:** closes open-telemetry#22056
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
**Description:** Adding a Double converter to pkg/ottl **Link to tracking Issue:** closes open-telemetry#22056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adding a Double converter to pkg/ottl
Link to tracking Issue:
closes #22056
Testing: I added similar tests as in func_int.go