-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl]: Add Double converter #22056
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@kamalmarhubi that is an ingenious workaround. This is definitely something we want to do. We already have |
@TylerHelmuth sure. Should it be called Float or Double? I thought Double made more sense because it's the name of the ValueType in pcommon, but open to either. |
Probably Double. @dmitryax @evan-bradley do you have an opinion? |
I agree with using Double |
Double makes sense to me as well. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Hello everyone! I have recently joined the community and I have started my contributions by working on "good first issue" tasks like this one. I wrote some code for this task here: #27457. Please let me know of any suggestions you have for it. |
**Description:** Adding a Double converter to pkg/ottl **Link to tracking Issue:** closes #22056
**Description:** Adding a Double converter to pkg/ottl **Link to tracking Issue:** closes open-telemetry#22056
**Description:** Adding a Double converter to pkg/ottl **Link to tracking Issue:** closes open-telemetry#22056
**Description:** Adding a Double converter to pkg/ottl **Link to tracking Issue:** closes open-telemetry#22056
Component(s)
pkg/ottl
Is your feature request related to a problem? Please describe.
There's currently an
Int
converter, but no obvious way to force a value to be aDouble
. If you have an attribute that's a string representation of a double, it'd be nice to just parse it the way you currently for string representations of integers withInt
.Describe the solution you'd like
Add a
Double
converter that can convertDouble
,Int
,String
values.Describe alternatives you've considered
The best I've come up with is going via JSON:
which does in fact work for Double, Int, and String.
Additional context
No response
The text was updated successfully, but these errors were encountered: