[chore] change completely how dependabot generates entries #27269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
dependabot_gen
branch
2 times, most recently
from
7fd3bf6
to
cf047e3
Compare
atoulme
force-pushed
the
dependabot_gen
branch
from
cf047e3
to
8074088
Compare
dmitryax
approved these changes
Sep 29, 2023
jpkrohling
approved these changes
Oct 2, 2023
| "github.com/google/go-github/v53/github" | ||
| "go.opentelemetry.io/collector/confmap/provider/fileprovider" | ||
| ) | ||
|
|
||
| const maxDependabotUpdates = 220 |
There was a problem hiding this comment.
Is this a limitation of dependabot? I remember we hit a limit there sometime ago -- is this the one?
There was a problem hiding this comment.
That is the one. See this part of the diff for the Makefile changes calling 220: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/27269/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L167
fatsheep9146
approved these changes
Oct 3, 2023
MovieStoreGuy
approved these changes
Oct 4, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…metry#27269) **Description:** Change entirely how dependabot update entries are generated, by using the metadata.yaml status to find which components are most important in the distribution. The code now takes into account the distributions and the stability of the component as a score to decide whether to push the component. Go modules that don't have an associated metadata.yaml are not considered and therefore not present in the module updates path. **Link to tracking Issue:** open-telemetry#19410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Change entirely how dependabot update entries are generated, by using the metadata.yaml status to find which components are most important in the distribution.
The code now takes into account the distributions and the stability of the component as a score to decide whether to push the component. Go modules that don't have an associated metadata.yaml are not considered and therefore not present in the module updates path.
Link to tracking Issue:
#19410
Testing:
Tested by running
make gendependabot