Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run into a limit on the number of modules that dependabot can handle #19410

Closed
dmitryax opened this issue Mar 8, 2023 · 8 comments · Fixed by #29472
Closed

Run into a limit on the number of modules that dependabot can handle #19410

dmitryax opened this issue Mar 8, 2023 · 8 comments · Fixed by #29472
Assignees
Labels
ci-cd CI, CD, testing, build issues dependencies Pull requests that update a dependency file help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed priority:p1 High

Comments

@dmitryax
Copy link
Member

dmitryax commented Mar 8, 2023

.github/dependabot.yml validation fails with

The property '#/updates' had more items than the allowed 200

https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/11858014604

Any suggestions are welcome.

For now, I'm going to limit the number of update rules to unblock dependabot

The error says the limit is 200, but we hit it after updating it from 220 to 221

@dmitryax dmitryax added bug Something isn't working dependencies Pull requests that update a dependency file priority:p1 High ci-cd CI, CD, testing, build issues labels Mar 8, 2023
@dmitryax dmitryax added the help wanted Extra attention is needed label Mar 8, 2023
@dmitryax
Copy link
Member Author

dmitryax commented Mar 9, 2023

Bringing it back to 220 didn't help — still the same error. Probably the limit was updated recently, and we run into it after updating dependabot.yml. I submitted a GitHub support ticket.

@codeboten codeboten self-assigned this Mar 10, 2023
@codeboten
Copy link
Contributor

I'll take a look at renovate next week, to see if it would be a good replacement. It may help with some of the other toil we have in the repo. It's also already in use in the opentelemetry-js repository.

codeboten pushed a commit that referenced this issue Apr 14, 2023
This moves updates for docker/docker-compose/github actions away from dependabot and over to renovatebot. Renovatebot will group PRs for those dependencies in a single pull request per dependency group.

Related issue: #19410

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label May 10, 2023
@codeboten codeboten added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels May 10, 2023
@codeboten
Copy link
Contributor

I think renovatebot can help us here. I've already started using it for docker/docker-compose/github action updates. I'm testing out ways we can use it for go packages as well.

@MitchellGale
Copy link
Contributor

Has there been any update on this? I believe we have hit the updated limit of 220 now. Should the limit be bumped to 240?

@mx-psi
Copy link
Member

mx-psi commented Jul 10, 2023

Has there been any update on this? I believe we have hit the updated limit of 220 now. Should the limit be bumped to 240?

@MitchellGale this is not a limit we control, but rather a limit of Dependabot/Github. While we could modify the limit on our Makefile target it wouldn't help here

MaxKsyunz added a commit to Bit-Quill/opentelemetry-collector-contrib that referenced this issue Jul 21, 2023
dependabot.yml reached maximum limit so a package is getting dropped but CI will fail without this change.

See open-telemetry#19410

Signed-off-by: Max Ksyunz <max.ksyunz@improving.com>
@songy23
Copy link
Member

songy23 commented Aug 4, 2023

@atoulme
Copy link
Contributor

atoulme commented Sep 29, 2023

I propose that we overhaul how dependabot is used by adding a metadata entry that selects if the module should be considered for dependabot updates. For similar components, we can then just elect one to be the receiver of updates, and drop all other ones. This should allow us to stay under the 200 components. We can also set a score of dependabot for components from 1 to 5, and sort them by score and pick the first 200 components.

dmitryax pushed a commit that referenced this issue Oct 4, 2023
**Description:**
Change entirely how dependabot update entries are generated, by using
the metadata.yaml status to find which components are most important in
the distribution.

The code now takes into account the distributions and the stability of
the component as a score to decide whether to push the component. Go
modules that don't have an associated metadata.yaml are not considered
and therefore not present in the module updates path.

**Link to tracking Issue:**

#19410
@codeboten codeboten removed the bug Something isn't working label Nov 6, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
…metry#27269)

**Description:**
Change entirely how dependabot update entries are generated, by using
the metadata.yaml status to find which components are most important in
the distribution.

The code now takes into account the distributions and the stability of
the component as a score to decide whether to push the component. Go
modules that don't have an associated metadata.yaml are not considered
and therefore not present in the module updates path.

**Link to tracking Issue:**

open-telemetry#19410
codeboten pushed a commit to codeboten/opentelemetry-collector-contrib that referenced this issue Nov 23, 2023
Fixes open-telemetry#19410

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit that referenced this issue Nov 24, 2023
Fixes
#19410

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues dependencies Pull requests that update a dependency file help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed priority:p1 High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants