[exporter/googlemanagedprometheus] Add target and scope info metrics by default #24372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
exporter/googlemanagedprometheus
damemi
force-pushed
the
gmp-exporter-add-target-metrics
branch
from
20a06c6
to
c9da95b
Compare
5 tasks
dashpole
reviewed
Jul 18, 2023
| @@ -54,6 +56,11 @@ func (c *GMPConfig) toCollectorConfig() collector.Config { | |||
| cfg.ProjectID = c.ProjectID | |||
| cfg.UserAgent = c.UserAgent | |||
| cfg.MetricConfig.ClientConfig = c.MetricConfig.ClientConfig | |||
| // add target_info and scope_info metrics | |||
There was a problem hiding this comment.
Can we add config for enabling/disabling these, similar to the PRW exporer: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/prometheusremotewriteexporter/config.go#L41 ?
There was a problem hiding this comment.
yup, added and enabled by default
damemi
force-pushed
the
gmp-exporter-add-target-metrics
branch
from
c9da95b
to
a557564
Compare
dashpole
approved these changes
Jul 19, 2023
|
I think you need to run |
damemi
force-pushed
the
gmp-exporter-add-target-metrics
branch
from
0563082
to
9d6a749
Compare
damemi
force-pushed
the
gmp-exporter-add-target-metrics
branch
from
34d00f4
to
ecd5e03
Compare
songy23
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This enabled
target_infoandotel_scope_infometrics by default in the GMP exporter, to be compatible with the prometheus spec.Link to tracking Issue: GoogleCloudPlatform/opentelemetry-operations-go#543
Testing: Downstream unit + integration tests
Documentation: Downstream + specification