Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GMP exporter should follow OTel -> Prometheus export conventions #543

Closed
5 tasks done
dashpole opened this issue Dec 7, 2022 · 3 comments · Fixed by #571
Closed
5 tasks done

GMP exporter should follow OTel -> Prometheus export conventions #543

dashpole opened this issue Dec 7, 2022 · 3 comments · Fixed by #571
Assignees
@damemi

Comments

@dashpole
Copy link
Contributor

dashpole commented Dec 7, 2022 •
edited by damemi
Loading

That includes:

  • Adding a target_info metric with resource attributes
  • Unit should be added as a suffix in metric names (before type suffixes)
  • Counters have a _total suffix added
  • otel_scope_info metric from scope
  • otel_scope_name and otel_scope_version attribute to all metrics within the scope, and to otel_scope_info
@damemi damemi self-assigned this Dec 7, 2022
@dashpole
Copy link
Contributor Author

I'm going to work on the metric name portion of this

@dashpole dashpole mentioned this issue Dec 21, 2022
Merged
@damemi damemi mentioned this issue Jan 10, 2023
Merged
@damemi damemi mentioned this issue Jan 17, 2023
Merged
@dashpole dashpole reopened this Jan 19, 2023
@damemi damemi mentioned this issue Jan 19, 2023
Merged
@damemi
Copy link
Contributor

damemi commented Jan 23, 2023

Closing via #574

@damemi damemi closed this as completed Jan 23, 2023
@damemi damemi mentioned this issue Jul 18, 2023
Merged
@damemi
Copy link
Contributor

damemi commented Jul 18, 2023

Just noticed we never enabled these upstream. Opened open-telemetry/opentelemetry-collector-contrib#24372 to add to contrib

codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this issue Jul 19, 2023
@damemi
[exporter/googlemanagedprometheus] Add target and scope info metrics …
c7bd50c 
…by default (#24372)

This enabled `target_info` and `otel_scope_info` metrics by default in
the GMP exporter, to be compatible with the prometheus spec.

**Link to tracking Issue:**
GoogleCloudPlatform/opentelemetry-operations-go#543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damemi damemi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add otel_scope_info metric to GMP exporter damemi/opentelemetry-operations-go
2 participants
@damemi @dashpole