Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fileconsumer] Deduplicate fingerprints less aggressively #24235

Merged
merged 2 commits into from
Jul 17, 2023
Merged

[fileconsumer] Deduplicate fingerprints less aggressively #24235

merged 2 commits into from
Jul 17, 2023

Commits on Jul 14, 2023

  1. [fileconsumer] Deduplicate fingerprints less aggressively 

    When finding files, we would check for files with duplicate fingerprints
and deduplicate them if a.StartsWith(b) or b.StartsWith(a). This StartsWith
logic is useful for recognizing files that have new content since the previous
poll interval. However, when deduplicating the results of the poll interval,
the only case that we need to consider is copy/truncate rotation. In this case,
a file may have been copied but the original has not yet been trucated. At that
moment we should expect to find two files with exactly the same fingerprint.
Therefore, we do not need to check StartsWith cases.
    @djaglowski
    djaglowski committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    0c01e35 View commit details
    Browse the repository at this point in the history

  2. Test fingerprint.Equal

    @djaglowski
    djaglowski committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    7a0afed View commit details
    Browse the repository at this point in the history