[fileconsumer] Deduplicate fingerprints less aggressively #24235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
strict-dedup
branch
2 times, most recently
from
0f83c6a
to
b23466d
Compare
atoulme
reviewed
Jul 13, 2023
When finding files, we would check for files with duplicate fingerprints and deduplicate them if a.StartsWith(b) or b.StartsWith(a). This StartsWith logic is useful for recognizing files that have new content since the previous poll interval. However, when deduplicating the results of the poll interval, the only case that we need to consider is copy/truncate rotation. In this case, a file may have been copied but the original has not yet been trucated. At that moment we should expect to find two files with exactly the same fingerprint. Therefore, we do not need to check StartsWith cases.
atoulme
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When finding files, we would check for files with duplicate fingerprints and deduplicate them if
a.StartsWith(b)orb.StartsWith(a). ThisStartsWithlogic is useful for recognizing files that have new content since the previous poll interval. However, when deduplicating files observed at the same moment, the only case that we need to consider is copy/truncate rotation. In this case, a file may have been copied but the original has not yet been truncated. At that moment we should expect to find two files with exactly the same fingerprint. Therefore, we do not need to check StartsWith cases.