Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov: Added 'third_party' ignore to match Makefile ALL_SRC #2391

Merged
merged 1 commit into from
Feb 22, 2021
Merged

codecov: Added 'third_party' ignore to match Makefile ALL_SRC #2391

merged 1 commit into from
Feb 22, 2021

Conversation

gramidt
Copy link
Member

@gramidt gramidt commented Feb 21, 2021

Description:
Added 'third_party' ignore within codecov to match Makefile ALL_SRC. The 'third_party' directory pattern is used in the windowsperfcounterreceiver and #2389.

Link to tracking Issue:
#2390

Testing:
N/A

Documentation:
N/A

Signed-off-by: Granville Schmidt 1246157+gramidt@users.noreply.github.com

@gramidt gramidt requested a review from a team February 21, 2021 16:04
@gramidt gramidt changed the title CODECOV: Added 'third_party' ignore within codecov to match Makefile ALL_SRC codecov: Added 'third_party' ignore within codecov to match Makefile ALL_SRC Feb 21, 2021
@gramidt gramidt changed the title codecov: Added 'third_party' ignore within codecov to match Makefile ALL_SRC codecov: Added 'third_party' ignore to match Makefile ALL_SRC Feb 21, 2021
This was referenced Feb 21, 2021
@bogdandrutu
Copy link
Member

@gramidt can you rebase?

Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
@gramidt
Copy link
Member Author

gramidt commented Feb 22, 2021

@bogdandrutu - Done.

@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #2391 (45dca76) into main (e9d82e0) will increase coverage by 4.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2391      +/-   ##
==========================================
+ Coverage   69.26%   73.69%   +4.42%     
==========================================
  Files          34      411     +377     
  Lines        1601    25431   +23830     
==========================================
+ Hits         1109    18742   +17633     
- Misses        418     6134    +5716     
- Partials       74      555     +481     
Flag Coverage Δ
integration 69.26% <ø> (ø)
unit 72.71% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
extension/httpforwarder/factory.go 100.00% <0.00%> (ø)
...porter/loadbalancingexporter/consistent_hashing.go 100.00% <0.00%> (ø)
exporter/logzioexporter/exporter.go 95.83% <0.00%> (ø)
exporter/datadogexporter/translate_traces.go 90.04% <0.00%> (ø)
exporter/sumologicexporter/test_data.go 100.00% <0.00%> (ø)
receiver/k8sclusterreceiver/receiver.go 100.00% <0.00%> (ø)
exporter/awsemfexporter/datapoint.go 100.00% <0.00%> (ø)
exporter/awsemfexporter/config.go 100.00% <0.00%> (ø)
...alibabacloudlogserviceexporter/metrics_exporter.go 100.00% <0.00%> (ø)
receiver/simpleprometheusreceiver/factory.go 100.00% <0.00%> (ø)
... and 389 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d82e0...45dca76. Read the comment docs.

@bogdandrutu bogdandrutu merged commit c8f146b into open-telemetry:main Feb 22, 2021
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
…2391)

Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants