-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): Bump github.com/aws/aws-sdk-go from 1.37.10 to 1.37.15 in /internal/awsxray #2409
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2409 +/- ##
==========================================
+ Coverage 73.69% 73.73% +0.03%
==========================================
Files 411 411
Lines 25431 25431
==========================================
+ Hits 18742 18752 +10
+ Misses 6134 6128 -6
+ Partials 555 551 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
adfb570
to
47606f3
Compare
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.37.10 to 1.37.15. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.37.10...v1.37.15) Signed-off-by: dependabot[bot] <support@github.com>
47606f3
to
f008d37
Compare
Superseded by #2439. |
* Fail in RunEndToEndTest if collector stop fails * Use testing T.Cleanup to check shut downs * Add goroutine leak detection * Fix TestExporterShutdown go leak The shutdown tests checking if a context error is honored did not completely clean up the resources used by the client after the error was evaluated. Update the connection client to handle multiple calls to shutdown and make a second call to these clients that must succeed so the test does not have abandoned goroutines. * Fix leak in TestNew_WithTimeout The mockTraceService did not delay with its lock being held. This resulted in the mockCollector stopping and being able to acquire the lock. It was assumed that no export was taking place because of this and the mockTraceService was abandoned without cleaning up resources it held and goroutines it had spawned. This reworks the export blocking logic to block on a channel read. This will make the block more deterministic and not depend on the scheduler timing. Additionally, this blocking is moved inside the lock acquire. Meaning code will deadlock if the block is not released before a shutdown (something the developer will immediately be aware of when they submit a bad patch), and will ensure all resources are released before shutdown. Replace TestNew_WithTimeout with TestExportSpansTimeoutHonored which directly tests if a span export errors when the timeout is reached. This is the only unique thing that TestNew_WithTimeout, but it also tests the non-error path. That non-error path is tested in many other tests. * Guard otlptracehttp client stopCh when stopping In normal operations the exporter is guaranteed to only ever call the client Stop method once. However in testing we need to call this multiple times when checking it returns an error in particular context. Add a lightweight sync.Once to the closing of the stopCh to ensure tests do not panic when cleaning up. * Release export block after export Prevent deadlock in TestExportSpansTimeoutHonored.
Bumps github.com/aws/aws-sdk-go from 1.37.10 to 1.37.15.
Release notes
Sourced from github.com/aws/aws-sdk-go's releases.
... (truncated)
Changelog
Sourced from github.com/aws/aws-sdk-go's changelog.
... (truncated)
Commits
800d50b
Release v1.37.15 (2021-02-19)6a40d08
aws: Add missing fields for config test. (#3740)083706b
aws/credentials/stscreds: Fix typo in StdinTokenProvider (#3791)d5c2145
Release v1.37.14 (2021-02-18) (#3789)39a0852
Presigned URL generation for Neptune and DocDB CopyDBClusterSnapshot & Create...c30a7b2
Release v1.37.13 (2021-02-17) (#3788)8d9532c
Release v1.37.12 (2021-02-16) (#3784)606788c
aws/client: Fix logging to allow it to be enabled per operation (#3778)8756523
Release v1.37.11 (2021-02-15) (#3781)6aa5fda
Release v1.37.10 (2021-02-12) (#3780)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)