Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump github.com/aws/aws-sdk-go from 1.37.10 to 1.37.15 in /internal/awsxray #2409

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 22, 2021

Bumps github.com/aws/aws-sdk-go from 1.37.10 to 1.37.15.

Release notes

Sourced from github.com/aws/aws-sdk-go's releases.

Release v1.37.15 (2021-02-19)

Service Client Updates

  • service/rds: Updates service API and documentation
    • Added awsBackupRecoveryPointArn in ModifyDBInstanceRequest and in the response of ModifyDBInstance.

Release v1.37.14 (2021-02-18)

Service Client Updates

  • service/cloudformation: Updates service API and documentation
    • Adding the 'callAs' parameter to all CloudFormation StackSets APIs except getTemplateSummary to support creating and managing service-managed StackSets with AWS Organizations Delegated Administrators
  • service/codebuild: Updates service API and documentation
    • AWS CodeBuild now allows you to specify a separate bucket owner as part of the S3 destination in a report group.
  • service/health: Updates service documentation
    • Documentation updates for health
  • service/sagemaker: Updates service API and documentation
    • This release adds expires-in-seconds parameter to the CreatePresignedDomainUrl API for support of a configurable TTL.

SDK Enhancements

  • service/neptune: Support for PreSignedUrl generation for CopyDBClusterSnapshot and CreateDBCluster operations. (#3782)
  • service/docdb: Support for PreSignedUrl generation for CopyDBClusterSnapshot and CreateDBCluster operations. (#3782)

Release v1.37.13 (2021-02-17)

Service Client Updates

  • service/config: Updates service API
  • service/ec2: Updates service API and documentation
    • This release includes a new filter for describe-vpc-endpoint-services.
  • service/lookoutvision: Updates service API and documentation

Release v1.37.12 (2021-02-16)

Service Client Updates

  • service/codebuild: Updates service API and documentation
    • This release provides per-project limits for the number of concurrent builds
  • service/devops-guru: Updates service API and documentation

SDK Bugs

  • aws/client: Fix logging to allow it to be enabled per operation
    • Allow logging of operation and request to be enabled per operation, not only per client or session.

Release v1.37.11 (2021-02-15)

Service Client Updates

  • service/config: Updates service API and documentation

... (truncated)

Changelog

Sourced from github.com/aws/aws-sdk-go's changelog.

Release v1.37.15 (2021-02-19)

Service Client Updates

  • service/rds: Updates service API and documentation
    • Added awsBackupRecoveryPointArn in ModifyDBInstanceRequest and in the response of ModifyDBInstance.

Release v1.37.14 (2021-02-18)

Service Client Updates

  • service/cloudformation: Updates service API and documentation
    • Adding the 'callAs' parameter to all CloudFormation StackSets APIs except getTemplateSummary to support creating and managing service-managed StackSets with AWS Organizations Delegated Administrators
  • service/codebuild: Updates service API and documentation
    • AWS CodeBuild now allows you to specify a separate bucket owner as part of the S3 destination in a report group.
  • service/health: Updates service documentation
    • Documentation updates for health
  • service/sagemaker: Updates service API and documentation
    • This release adds expires-in-seconds parameter to the CreatePresignedDomainUrl API for support of a configurable TTL.

SDK Enhancements

  • service/neptune: Support for PreSignedUrl generation for CopyDBClusterSnapshot and CreateDBCluster operations. (#3782)
  • service/docdb: Support for PreSignedUrl generation for CopyDBClusterSnapshot and CreateDBCluster operations. (#3782)

Release v1.37.13 (2021-02-17)

Service Client Updates

  • service/config: Updates service API
  • service/ec2: Updates service API and documentation
    • This release includes a new filter for describe-vpc-endpoint-services.
  • service/lookoutvision: Updates service API and documentation

Release v1.37.12 (2021-02-16)

Service Client Updates

  • service/codebuild: Updates service API and documentation
    • This release provides per-project limits for the number of concurrent builds
  • service/devops-guru: Updates service API and documentation

SDK Bugs

  • aws/client: Fix logging to allow it to be enabled per operation
    • Allow logging of operation and request to be enabled per operation, not only per client or session.

Release v1.37.11 (2021-02-15)

Service Client Updates

  • service/config: Updates service API and documentation

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from anuraaga as a code owner February 22, 2021 05:44
@dependabot dependabot bot requested a review from a team February 22, 2021 05:44
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 22, 2021
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #2409 (adfb570) into main (4822592) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2409      +/-   ##
==========================================
+ Coverage   73.69%   73.73%   +0.03%     
==========================================
  Files         411      411              
  Lines       25431    25431              
==========================================
+ Hits        18742    18752      +10     
+ Misses       6134     6128       -6     
+ Partials      555      551       -4     
Flag Coverage Δ
integration 69.26% <ø> (ø)
unit 72.75% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
receiver/k8sclusterreceiver/watcher.go 97.64% <0.00%> (+2.35%) ⬆️
receiver/prometheusexecreceiver/receiver.go 88.33% <0.00%> (+2.50%) ⬆️
exporter/signalfxexporter/dimensions/requests.go 92.15% <0.00%> (+9.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4efc97e...47606f3. Read the comment docs.

@gramidt
Copy link
Member

gramidt commented Feb 22, 2021

Codecov should pass once #2391 and #2389 are merged.

@dependabot dependabot bot force-pushed the dependabot/go_modules/internal/awsxray/github.com/aws/aws-sdk-go-1.37.15 branch from adfb570 to 47606f3 Compare February 22, 2021 18:12
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.37.10 to 1.37.15.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.37.10...v1.37.15)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/internal/awsxray/github.com/aws/aws-sdk-go-1.37.15 branch from 47606f3 to f008d37 Compare February 22, 2021 18:47
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 22, 2021

Superseded by #2439.

@dependabot dependabot bot closed this Feb 22, 2021
@dependabot dependabot bot deleted the dependabot/go_modules/internal/awsxray/github.com/aws/aws-sdk-go-1.37.15 branch February 22, 2021 20:23
kisieland referenced this pull request in kisieland/opentelemetry-collector-contrib Mar 16, 2021
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* Fail in RunEndToEndTest if collector stop fails

* Use testing T.Cleanup to check shut downs

* Add goroutine leak detection

* Fix TestExporterShutdown go leak

The shutdown tests checking if a context error is honored did not
completely clean up the resources used by the client after the error was
evaluated. Update the connection client to handle multiple calls to
shutdown and make a second call to these clients that must succeed so
the test does not have abandoned goroutines.

* Fix leak in TestNew_WithTimeout

The mockTraceService did not delay with its lock being held. This
resulted in the mockCollector stopping and being able to acquire the
lock. It was assumed that no export was taking place because of this and
the mockTraceService was abandoned without cleaning up resources it held
and goroutines it had spawned. This reworks the export blocking logic to
block on a channel read. This will make the block more deterministic and
not depend on the scheduler timing. Additionally, this blocking is moved
inside the lock acquire. Meaning code will deadlock if the block is not
released before a shutdown (something the developer will immediately be
aware of when they submit a bad patch), and will ensure all resources
are released before shutdown.

Replace TestNew_WithTimeout with TestExportSpansTimeoutHonored which
directly tests if a span export errors when the timeout is reached. This
is the only unique thing that TestNew_WithTimeout, but it also tests the
non-error path. That non-error path is tested in many other tests.

* Guard otlptracehttp client stopCh when stopping

In normal operations the exporter is guaranteed to only ever call the
client Stop method once. However in testing we need to call this
multiple times when checking it returns an error in particular context.
Add a lightweight sync.Once to the closing of the stopCh to ensure tests
do not panic when cleaning up.

* Release export block after export

Prevent deadlock in TestExportSpansTimeoutHonored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants