Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[changelog] Move missed changelog entry into 0.55.0 release notes #12171

Merged
merged 1 commit into from
Jul 7, 2022
Merged

[changelog] Move missed changelog entry into 0.55.0 release notes #12171

merged 1 commit into from
Jul 7, 2022

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Jul 7, 2022 •
edited
Loading

The change was included into the 0.55.0 release but didn't make into the generated Changelog

Changelog was generated (#12134) before #12105 got merged.

Raised here #11815 (comment)

cc @TylerHelmuth

@dmitryax
[changelog] Move missed changelog entry into 0.55.0 release notes
70ff872 
The change was included into the 0.55.0 release but didn't make into the generated Changelog
@dmitryax dmitryax requested review from a team and pmm-sumo July 7, 2022 21:00
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 7, 2022
@dmitryax
Copy link
Member Author

dmitryax commented Jul 7, 2022 •
edited
Loading

@djaglowski do you think it's possible apply some solution to avoid such issues going forward? Is it worth creating an issue?

@dmitryax dmitryax mentioned this pull request Jul 7, 2022
Closed
14 tasks
@codeboten codeboten added the ready to merge Code review completed; ready to merge by maintainers label Jul 7, 2022
@djaglowski
Copy link
Member

I think that if we merge additional changes after the CHANGELOG.md has been generated for a release, then we should expect to also update the CHANGELOG.md manually. Perhaps this needs to be clarified in the release process? Not sure what else we would do here.

@djaglowski djaglowski merged commit 63968d6 into open-telemetry:main Jul 7, 2022
@dmitryax dmitryax mentioned this pull request Sep 16, 2022
Closed
@bogdandrutu
Copy link
Member

@jpkrohling just want to say that can happen with the tool as well :))

Context: open-telemetry/opentelemetry-collector#6087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@djaglowski djaglowski djaglowski approved these changes

@codeboten codeboten codeboten approved these changes

@pmm-sumo pmm-sumo Awaiting requested review from pmm-sumo

Assignees

@mx-psi mx-psi

Labels
ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dmitryax @djaglowski @bogdandrutu @codeboten @TylerHelmuth @mx-psi